-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for meteor/apollo v3 #3739
Conversation
Thanks for this @lorensr! Actually, we've been talking about the Meteor integration docs a fair bit recently. Given that you're planning on releasing a 3.0.0 version of https://github.com/apollographql/meteor-integration, does that mean you (or someone else) will be supporting/maintaining it? We were under the impression that it is currently unmaintained (due to the repo's README), and we were planning on completely removing most of Apollo's Meteor integration section. We were going to instead replace that full section with a single page, that links to modern and maintained community approaches for integrating Meteor and Apollo. As things stand currently, our preference is to point people towards using https://github.com/Swydo/ddp-apollo, since it's actively maintained. If someone is taking over the So long story short - if the |
Happy to keep maintaining it, and to direct people to @Swydo—lmk if there
are other differences I should note in the beginning of the docs
…On Tue, Jul 31, 2018 at 10:40 AM Hugh Willson ***@***.***> wrote:
Thanks for this @lorensr <https://github.com/lorensr>! Actually, we've
been talking about the Meteor integration docs a fair bit recently. Given
that you're planning on releasing a 3.0.0 version of
https://github.com/apollographql/meteor-integration, does that mean you
(or someone else) will be supporting/maintaining it? We were under the
impression that it is currently unmaintained (due to the repo's README),
and we were planning on completely removing most of Apollo's Meteor
integration section. We were going to instead replace that full section
with a single page, that links to modern and maintained community
approaches for integrating Meteor and Apollo. As things stand currently,
our preference is to point people towards using
https://github.com/Swydo/ddp-apollo, since it's actively maintained. If
someone is taking over the apollo package though, great!
So long story short - if the apollo package is going to be maintained by
someone, we'll definitely get these changes merged in. If it's not though,
we're likely moving ahead with reducing this section greatly. Let me know -
thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3739 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPVmKTxb9SrUz653rq9z2cfDIJYLFzzks5uMGxGgaJpZM4Vg_NE>
.
|
Okay, thanks @lorensr. I'll add a few adjustments here (and will likely remove the subscriptions section completely since @theodorDiaconu I know you're doing a lot of interesting things with regards to Meteor + Apollo integration. Once we have this section cleaned up a bit, if you're interested in adding a reference to your https://github.com/cult-of-coders/apollo project, let me know. Thanks! |
@hwillson can you define what kind of reference you mean ? |
@theodorDiaconu I just meant that in the Meteor + Apollo section, we're mentioning the |
@hwillson v3 of |
Good work with the new content so far, guys. It has been much needed. You can remove the instructions to install Please update the Subscriptions section to show new syntax and examples (that work) with Thank you. |
I think I've worked out how to do Subscriptions client-side. Feel free to use this to replace the old code.
|
Can we see some working code for using the built-in subscription server in Apollo Server? I've been having some trouble. See my code at apollographql/apollo-server#1537 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @lorensr!
I'm going to merge this as is. @tab00, any chance you'd like to create a separate PR with the subscription section changes? Thanks all! |
v3: apollographql/meteor-integration#124
Will release when this is merged. Maybe there's a better way to connect to
WebApp
, maybe @abernix knows? Currently recommending: