Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codegen async/await Mega PR #57

Merged
merged 100 commits into from Oct 26, 2023
Merged

Codegen async/await Mega PR #57

merged 100 commits into from Oct 26, 2023

Conversation

AnthonyMDev
Copy link
Contributor

This PR:

  • Refactors the entire codegen engine to use async/await
  • Adds the ability to pass a custom async closure to ApolloCodegen in order to customize the computation of operation identifiers for the persisted queries manifest.
  • Updates the apollo-ios-cli to use AsyncParsableCommand in order to work with the new async codegen engine

In order to get codegen working with Swift Concurrency, a lot of code had to be restructured.

BobaFetters and others added 30 commits August 24, 2023 16:14
@BobaFetters
Updating apollo-ios-codegen to main
18ef1ca
@BobaFetters
Adding test location note to subtrees (#27)
7072f46
@BobaFetters
Updating contributing guides (#23)
48b6461
@BobaFetters
split: apollo-ios-codegen - Updating READMEs and ci workflow name (#24)
94ef89e
@BobaFetters
Updating to current main (#32)
4a5f45b
@AnthonyMDev
Break out GraphQLCompiler and TemplateString (#35)
a3d2ce4
@AnthonyMDev
Breakout Codegen IR to separate module (#37)
b5e0cf1
@AnthonyMDev
Add referencedFragments to CompilationResult (#39)
c4f7eaa
@BobaFetters
Adding ci to auto close PRs (#41)
ceea2e8
@BobaFetters
Updating to latest main from apollo-ios (#42)
c6d829c
@BobaFetters
Readding missing imports (#43)
134524a
@AnthonyMDev
Attempt CI fix
0fc178e
@AnthonyMDev
Attempt CI fix
2ba5fd3
@AnthonyMDev
Fix Package build error
24a96e5
@AnthonyMDev
Fix Package build error
d03d45e
@AnthonyMDev
whitespace
f3eaa97
@AnthonyMDev
whitespace
751f962
@AnthonyMDev
Make OperationIdentifierFactory take provider closure
14bcf17
@AnthonyMDev
Make OperationIdentifierFactory take provider closure
95f04b5
@AnthonyMDev
OperationIdentifierProvider error handling
f71aa53
@AnthonyMDev
OperationIdentifierProvider error handling
36069f9
@AnthonyMDev
Refactor Operation Manifest and OperationDescription
23434a1
@AnthonyMDev
Refactor Operation Manifest and OperationDescription
fae5b9f
@AnthonyMDev
Refactor Codegen to use an instance of itself
c9134c2
@AnthonyMDev
Refactor Codegen to use an instance of itself
106b76d
@AnthonyMDev
WIP: Make codegen async
84cf15d
@AnthonyMDev
WIP: Make codegen async
a998846
@AnthonyMDev
Get minimal async codegen building.
43b082e
@AnthonyMDev
Get minimal async codegen building.
1b6072c
@AnthonyMDev
WIP: getting unit tests running.
ae37924
@AnthonyMDev AnthonyMDev marked this pull request as draft October 10, 2023 18:22
AnthonyMDev and others added 15 commits October 12, 2023 10:45
@AnthonyMDev
Merge remote-tracking branch 'origin/main' into codegen-custom-operat…
908fd7e 
…ion-id
@AnthonyMDev
Merge remote-tracking branch 'origin/main' into codegen-custom-operat…
e7567e0 
…ion-id
@jimisaacs
Inject network session for schema download (#1)
a971139
@AnthonyMDev
Merge commit 'a971139faeae01aaf77dee847c2308efb6afd24e' into codegen-…
6b1dcc0 
…custom-operation-id

# Conflicts:
#	apollo-ios-codegen/Sources/ApolloCodegenLib/ApolloCodegen.swift
#	apollo-ios-codegen/Sources/ApolloCodegenLib/ApolloSchemaDownloader.swift
#	apollo-ios-codegen/Sources/ApolloCodegenLib/OperationDescriptor.swift
#	apollo-ios-codegen/Sources/CodegenCLI/Commands/FetchSchema.swift
#	apollo-ios-codegen/Sources/CodegenCLI/Commands/Generate.swift
#	apollo-ios-codegen/Sources/CodegenCLI/Protocols/SchemaDownloadProvider.swift
#	apollo-ios-codegen/Sources/IR/IR+RootFieldBuilder.swift
@AnthonyMDev
Fix CLI tests for session injection in mocks
e4cf9f2
@AnthonyMDev
Implement ConcurrentCompactMap utility
f03ebab
@AnthonyMDev
Isolate output folder for codgen unit tests
4b2e74b
@AnthonyMDev
Removing invalid tests
c84d995
@AnthonyMDev
Fix server integration tests
11bbda7
@AnthonyMDev
More test fixes!
5df0a2f
@AnthonyMDev
Merge remote-tracking branch 'origin/main' into codegen-custom-operat…
2ad2390 
…ion-id
@AnthonyMDev
Sendable usage corrections
52e87ec
@AnthonyMDev
Make JavaScriptBridge run on main thread executor
6218e97 
This corrects an issue with deallocation of lots of JSValues for all the AST nodes overflowing the stack limits on async thread.

https://forums.swift.org/t/exc-bad-access-using-withtaskgroup-depending-on-size-of-data/54506/16
@AnthonyMDev
Make JavaScriptBridge use weak references to JSValues
11b6456
@AnthonyMDev
Make JavaScriptBridge use ObjectIdentifiers to JSValues
20d22a0
@AnthonyMDev AnthonyMDev marked this pull request as ready for review October 25, 2023 21:27
AnthonyMDev
AnthonyMDev commented Oct 26, 2023
View reviewed changes
Copy link
Contributor Author

@AnthonyMDev AnthonyMDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've done an entire review of this with the team on a Zoom call for approval.

@AnthonyMDev AnthonyMDev merged commit f08c0b5 into main Oct 26, 2023
7 of 8 checks passed
@AnthonyMDev AnthonyMDev deleted the codegen-custom-operation-id branch October 26, 2023 18:57
BobaFetters pushed a commit that referenced this pull request Oct 26, 2023
@AnthonyMDev
Codegen async/await Mega PR (#57)
266d3a6
BobaFetters pushed a commit to apollographql/apollo-ios-codegen that referenced this pull request Oct 26, 2023
@AnthonyMDev
Codegen async/await Mega PR (apollographql/apollo-ios-dev#57)
7246747
BobaFetters pushed a commit that referenced this pull request Oct 26, 2023
Squashed 'apollo-ios-codegen/' changes from 6a23feda..72467475
f1f76b3 
72467475 Codegen async/await Mega PR (#57)

git-subtree-dir: apollo-ios-codegen
git-subtree-split: 724674751239f30176ebdd0581f2f70bc6e250f2
BobaFetters pushed a commit that referenced this pull request Oct 26, 2023
split: apollo-ios-codegen - PR #57 - Codegen async/await Mega PR
a9a7934 
git-subtree-dir: apollo-ios-codegen
git-subtree-mainline: 266d3a6
git-subtree-split: 724674751239f30176ebdd0581f2f70bc6e250f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvincestari calvincestari Awaiting requested review from calvincestari

@BobaFetters BobaFetters Awaiting requested review from BobaFetters

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@AnthonyMDev @BobaFetters @svc-secops @jimisaacs