-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix file name discrepancies and bring attention to server null data no errors issue in Kotlin Tutorial #5740
Fix file name discrepancies and bring attention to server null data no errors issue in Kotlin Tutorial #5740
Conversation
@YuanRuQian: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for catching those ❤️
You're also 100% right on the behaviour change about errors vs null. Nullability in GraphQL is one of my favorite topics, I'll investigate this with the team and report here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
(keeping this open for now as a reminder that we still need to investigate the tutorial issue). I'll merge and open a separate tutorial issue at the end of the week if we haven't figured it out before that! |
Fixing the tutorial might take a bit of time. Merging this as-is as opened #5747 as a follow up. Thanks again 🙏 |
… (#5748) Co-authored-by: Lydia Yuan <32387159+YuanRuQian@users.noreply.github.com>
…ios12-compat * commit 'b8e8bdba951b1cb9beecabfc80433d848b2c921b': (38 commits) release 3.8.5 Fix mapping of the builtin Float scalar type (apollographql#6047) SqlNormalizedCacheFactory make sqldriver public to support Sqlcipher data encryption. (apollographql#5972) Update 08-add-a-details-view.mdx for additional state handling (apollographql#5975) adding checks for json end_document in http batching interceptors (apollographql#5892) adding checks for json end_document in http transport (apollographql#5894) [3.x] Bump okio to 3.9.0 (apollographql#5868) version is now 3.8.5-SNAPSHOT release 3.8.4 Backport apollographql#5848 to the v3 branch (apollographql#5863) Backport apollographql#5840 to the v3 branch (apollographql#5861) Backport apollographql#5778 to the v3 branch (apollographql#5860) Update min version of Kotlin in README and doc (apollographql#5750) version is now 3.8.4-SNAPSHOT release 3.8.3 Add deprecations on symbols that are getting removed in v4 (apollographql#5746) docs: Correct file name discrepancies in tutorial documentation (apollographql#5740) Ignore IOException when calling ApolloHttpCache.remove (apollographql#5730) Added an implementation of a missing NSURLSessionWebSocketDelegateProtocol method in the NSURLSessionWebSocketEngine that's required in order to get a web socket to successfully reopen. (apollographql#5704) Update plugin-configuration.mdx (apollographql#5673) ... # Conflicts: # gradle.properties # libraries/apollo-runtime/src/appleMain/kotlin/com/apollographql/apollo3/network/ws/NSURLSessionWebSocketEngine.kt
Hi, I mentioned these issues in my Discord post
Changes Made:
Additionally, In the "Add a Details View" section , I observed a discrepancy in the behavior of the current server demo when handling invalid IDs. According to the expected behavior, the server should return errors when provided with invalid IDs. However, upon testing by providing invalid IDs in the query, all responses contained only null data but no errors. Maybe the dev team to investigate this issue to ensure new learners encounter the expected behavior.
Query:
Query Variables:
Expected response:
Actual response:
Thank you!