Skip to content

Commit

Permalink
Revert "Update dependencies accept & boom to new namespace (#30… (#3111)
Browse files Browse the repository at this point in the history
This reverts commits 0de2942, 97b3f68 and 293e28d.

While the change in #3089 change was seemingly justified and straightforward
(and as #3106 points out, perhaps _too_ straightforward!  😄), it seems
that there was more to the change from `accept` to `@hapi/accept` and `boom`
to `@hapi/boom` than just a name change.  It seems that the packages may
have dropped support for Node.js 6.

While Node.js 6 is no longer supported by the Node Foundation, for
semantic versioning reasons we weren't intending to completely drop support
for it until Apollo Server 3.x.

Maybe there's a more granular update here that maintains this support, but
this update wasn't as simple as it would have seemed to be at face value
(i.e. not a straight package rename of an otherwise internal dependency).

Happy to consider re-landing a similar thing, but we need to make it more
clear in the `CHANGELOG.md` and possibly reserve it for Apollo Server 3.x,
but for now, should revert this to make sure we're not shipping a broken
integration for Hapi users, as reported in #3106.
  • Loading branch information
abernix committed Jul 30, 2019
1 parent e6ccd8b commit 0d27c58
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 26 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ The version headers in this history reflect the versions of Apollo Server itself

> The changes noted within this `vNEXT` section have not been released yet. New PRs and commits which introduce changes should include an entry in this `vNEXT` section as part of their development. When a release is being prepared, a new header will be (manually) created below and the the appropriate changes within that release will be moved into the new section.
- `apollo-server-hapi`: Revert switch from `accept` and `boom` which took place in v2.8.0. [PR #3089](https://github.com/apollographql/apollo-server/pull/3089)
- `@apollo/gateway`: Change the `setInterval` timer, which is used to continuously check for updates to a federated graph from the Apollo Graph Manager, to be an `unref`'d timer. Without this change, the server wouldn't terminate properly once polling had started since the event-loop would continue to have unprocessed events on it. [PR #3105](https://github.com/apollographql/apollo-server/pull/3105)

### v2.8.0
Expand Down
26 changes: 2 additions & 24 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/apollo-server-hapi/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@
},
"dependencies": {
"@apollographql/graphql-playground-html": "1.6.24",
"@hapi/accept": "^3.2.2",
"@hapi/boom": "^7.4.2",
"accept": "^3.0.2",
"apollo-server-core": "file:../apollo-server-core",
"apollo-server-types": "file:../apollo-server-types",
"boom": "^7.1.0",
"graphql-subscriptions": "^1.0.0",
"graphql-tools": "^4.0.0"
},
Expand Down

0 comments on commit 0d27c58

Please sign in to comment.