Skip to content

Commit

Permalink
Reinstate @apollo/protobufjs fork (#3539)
Browse files Browse the repository at this point in the history
* Revert "Revert protobuf changes (#3537)"

This reverts commit 450da57.

* Version bump to 1.0.3
  • Loading branch information
trevor-scheer committed Nov 21, 2019
1 parent 7ff988a commit 7ac7eeb
Show file tree
Hide file tree
Showing 4 changed files with 35 additions and 33 deletions.
4 changes: 3 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@ The version headers in this history reflect the versions of Apollo Server itself

> The changes noted within this `vNEXT` section have not been released yet. New PRs and commits which introduce changes should include an entry in this `vNEXT` section as part of their development. When a release is being prepared, a new header will be (manually) created below and the the appropriate changes within that release will be moved into the new section.
- Reinstate [PR #3530](https://github.com/apollographql/apollo-server/pull/3530) via [#3539](https://github.com/apollographql/apollo-server/pull/3539) - after a patch release of the `@apollo/protobufjs` fork, the build issue for consumers should be resolved.

### v2.9.11

- Revert [PR #3530](https://github.com/apollographql/apollo-server/pull/3530) - the introduction of the `@apollo/protobufjs` fork is causing TS errors in consumer projects. Reverting this change for now, and will reintroduce it after the issue is resolved within the forked package.
- Revert [PR #3530](https://github.com/apollographql/apollo-server/pull/3530) via [#3535](https://github.com/apollographql/apollo-server/pull/3535)- the introduction of the `@apollo/protobufjs` fork is causing TS errors in consumer projects. Reverting this change for now, and will reintroduce it after the issue is resolved within the forked package.

### v2.9.10

Expand Down
56 changes: 28 additions & 28 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions packages/apollo-engine-reporting-protobuf/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
"types": "dist/index.d.ts",
"scripts": {
"prepare": "npm run pbjs && npm run pbts && cp src/* dist",
"pbjs": "bash -c 'mkdir -p dist && pbjs --target static-module --out dist/protobuf.js --wrap commonjs --force-number <(grep -v \"package mdg.engine.proto\" src/reports.proto)'",
"pbts": "pbts -o dist/protobuf.d.ts dist/protobuf.js"
"pbjs": "bash -c 'mkdir -p dist && apollo-pbjs --target static-module --out dist/protobuf.js --wrap commonjs --force-number <(grep -v \"package mdg.engine.proto\" src/reports.proto)'",
"pbts": "apollo-pbts -o dist/protobuf.d.ts dist/protobuf.js"
},
"repository": {
"type": "git",
Expand All @@ -27,6 +27,6 @@
},
"homepage": "https://github.com/apollographql/apollo-engine-reporting#readme",
"dependencies": {
"protobufjs": "^6.8.6"
"@apollo/protobufjs": "^1.0.3"
}
}
2 changes: 1 addition & 1 deletion packages/apollo-engine-reporting-protobuf/src/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const protobuf = require('./protobuf');
const protobufJS = require('protobufjs/minimal');
const protobufJS = require('@apollo/protobufjs/minimal');

// Remove Long support. Our uint64s tend to be small (less
// than 104 days).
Expand Down

0 comments on commit 7ac7eeb

Please sign in to comment.