Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate @apollo/protobufjs fork #3539

Merged
merged 3 commits into from Nov 21, 2019

Conversation

trevor-scheer
Copy link
Member

@trevor-scheer trevor-scheer commented Nov 21, 2019

Reinstate the @apollo/protobufjs fork after resolving TS build issues in a patch release.

For reference:
#3535
#3530

Closes #3312

@trevor-scheer
Copy link
Member Author

Tested these builds internally and didn't encounter the same TS issues as I did before. The previous issue seems to be resolved.

@trevor-scheer trevor-scheer merged commit 7ac7eeb into master Nov 21, 2019
@trevor-scheer trevor-scheer deleted the trevor/reinstate-apollo-protobufjs-fork branch November 21, 2019 17:26
trevor-scheer added a commit that referenced this pull request Nov 21, 2019
The package-lock.json file wasn't updated correctly in PR #3539.
This updates @apollo/protobufjs to the latest version (1.0.3)
@abernix abernix added this to the Release 2.9.12 milestone Dec 17, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reporting protobuf: conflict with other libraries
2 participants