Skip to content

Commit

Permalink
Add production dependency on @types/node-fetch.
Browse files Browse the repository at this point in the history
As the `HeadersInit` is exported and used in the exported [`GatewayConfig`]
type via [`RemoteGatewayConfig`] - which is emitted to `@apollo/gateway`'s
`dist/index.d.ts` declaration, the `node-fetch` types need to be available
by those who install the package.

[`GatewayConfig`]: https://github.com/apollographql/apollo-server/blob/73cdf0d533908894282debdb6dc5444186af27a6/packages/apollo-gateway/src/index.ts#L74-L77
[`RemoteGatewayConfig`]: https://github.com/apollographql/apollo-server/blob/73cdf0d533908894282debdb6dc5444186af27a6/packages/apollo-gateway/src/index.ts#L62
  • Loading branch information
abernix committed Nov 22, 2019
1 parent 4316883 commit ee36267
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
11 changes: 11 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/apollo-gateway/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
},
"dependencies": {
"@apollo/federation": "file:../apollo-federation",
"@types/node-fetch": "2.5.4",
"apollo-engine-reporting-protobuf": "file:../apollo-engine-reporting-protobuf",
"apollo-env": "^0.5.1",
"apollo-graphql": "^0.3.4",
Expand Down

0 comments on commit ee36267

Please sign in to comment.