Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to a fork of apollo-upload-server to fix missing core-js dependency. #1556

Merged
merged 3 commits into from
Aug 20, 2018
Merged

Switch to a fork of apollo-upload-server to fix missing core-js dependency. #1556

merged 3 commits into from
Aug 20, 2018

Commits on Aug 20, 2018

  1. Switch to a fork of apollo-upload-server to fix missing core-js d… 

    …ependency.

As reported in #1542,
the `apollo-upload-server` package (v5.0.0, which `apollo-server` relies on)
is no longer able to provide a `core-js` package because of change that was
outside of its control in a Babel release.

The problem is resolved in newer versions of `apollo-upload-server`,
however, regrettably, the newer versions of that package (notably, v6 and
v7) drop support for Node.js 6 — one of two versions of Node.js that are
currently under the terms of the Node.js Foundation's Long-Term-Support
(LTS) agreements.

Since Apollo Server aims to support versions of Node.js which are under LTS
(and will drop support for Node.js 6 in April 2019, per Node.js' schedule)
the current, immediate solution is to fork the `apollo-upload-server`
package as `@apollographql/apollo-upload-server`.

With the inclusion of
https://github.com/apollographql/apollo-upload-server/pull/1, we are able to
keep supporting Node.js 6.  Without this change, every new installation
of `apollo-server`, which doesn't have a `package-lock.json` preventing
transitive dependency updates - specifically, the updates to
`@babel/runtime` versions newer than `-beta.56` - is broken.
    @abernix
    abernix committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    5a91936 View commit details
    Browse the repository at this point in the history

  2. [squash] Update to @apollographql/apollo-upload-server@5.0.2.

    @abernix
    abernix committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    9e8312c View commit details
    Browse the repository at this point in the history

  3. [squash] Update to @apollographql/apollo-upload-server@5.0.3.

    @abernix
    abernix committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    5a73d87 View commit details
    Browse the repository at this point in the history