Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable setting of content-type #2520

Merged
merged 6 commits into from May 23, 2019

Conversation

jlally21
Copy link
Contributor

@jlally21 jlally21 commented Apr 1, 2019

requests were setting Content-Type to application/json, even if a custom Content-Type had been set previously. This change enables the setting of a custom Content-Type, like application/vnd.api+json.

Issue: #2035

@apollo-cla
Copy link

@jlally21: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@saernz
Copy link

saernz commented Apr 11, 2019

Oh thank God, someone made a PR! This is an annoying bug for sure. Please someone merge this! 😛

@drewbarontini
Copy link

Our team just ran into this issue today, and would love to get this PR merged in. Anything we can do to help push it through?

@jlally21
Copy link
Contributor Author

jlally21 commented May 3, 2019

@drewbarontini Yes, we would like to get it pushed through as well! Unfortunately, I am not too familiar with the PR approval process for apollo-server as this is the first PR I've opened for this project.

If anyone has any insight on how to get the PR reviewed and merged in, please let us know!

@drewbarontini
Copy link

@jlally21 It looks like you need to sign the Meteor Contributor Agreement, if you haven't already. And there are a few file conflicts that I'm sure need to be resolved. It looks like the "Small bug fixes" section outlines what needs to be done:

For a small bug fix change (less than 20 lines of code changed), feel free to open a pull request. We’ll try to merge it as fast as possible and ideally publish a new release on the same day. The only requirement is, make sure you also add a test that verifies the bug you are trying to fix.

So there might need to be a test written for this fix in order to get merged in.

@laarakus
Copy link

Hello guys, any updates on this PR?

@abernix abernix merged commit accf3eb into apollographql:master May 23, 2019
@abernix
Copy link
Member

abernix commented May 23, 2019

Thanks so much for submitting this! I'll get this into an upcoming 2.6.0 alpha real soon.

@abernix abernix added this to the Release 2.6.0 milestone May 23, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants