Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable callbackWaitsForEmptyEventLoop #2638

Merged
merged 2 commits into from May 13, 2019
Merged

disable callbackWaitsForEmptyEventLoop #2638

merged 2 commits into from May 13, 2019

Commits on May 1, 2019

  1. disable callbackWaitsForEmptyEventLoop 

    Disable callbackWaitsForEmptyEventLoop for HTTP OPTIONS request since ApolloServer already disable callbackWaitsForEmptyEventLoop for POST request. (https://github.com/apollographql/apollo-server/blob/1ec2890397ca306350b0e1f33eec7b5f3f951d8d/packages/apollo-server-lambda/src/lambdaApollo.ts#L33)

Otherwise is lambda event loop is not empty, subsequence HTTP OPTIONS request will be hang and even timeout without throwing proper error.
    @bluedusk
    bluedusk committed May 1, 2019
    Copy the full SHA
    0e118b6 View commit details
    Browse the repository at this point in the history

  2. fix prettier issue 

    fix prettier issue
    @bluedusk
    bluedusk committed May 1, 2019
    Copy the full SHA
    99df738 View commit details
    Browse the repository at this point in the history