Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always send variables required for query #2867

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Always send variables required for query #2867

merged 1 commit into from
Jun 17, 2019

Conversation

hannesj
Copy link
Contributor

@hannesj hannesj commented Jun 17, 2019

Fixes #2866

@jbaxleyiii jbaxleyiii merged commit ed84d86 into apollographql:master Jun 17, 2019
@JacksonKearl
Copy link

I think these tests might only pass if you're east of the prime meridian. Failing in America/Los_Angeles at least.

@JacksonKearl
Copy link 

> new Date('1815-12-10').toLocaleString('en-US', {timeZone: "America/Los_Angeles"})
'12/9/1815, 4:07:02 PM'

Dates...

@JacksonKearl JacksonKearl mentioned this pull request Jun 17, 2019
Merged
abernix pushed a commit to apollographql/federation that referenced this pull request Sep 4, 2020
Merge pull request apollographql/apollo-server#2867 from hannesj/master
b26f6f2 
Always send variables required for query
Apollo-Orig-Commit-AS: apollographql/apollo-server@ed84d86
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jbaxleyiii jbaxleyiii jbaxleyiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Federation Gateway does not send variables in non-root queries
3 participants
@hannesj @JacksonKearl @jbaxleyiii