Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix causing multiple operations to sometimes be incorrectly executed #3084

Merged
merged 2 commits into from
Jul 25, 2019

Conversation

JacksonKearl
Copy link

@JacksonKearl JacksonKearl commented Jul 25, 2019

We were caching the query plan based on only the query hash, which gave problems when operationName was different for the same query.

@JacksonKearl JacksonKearl changed the title Fix causing operation name to sometimes be incorrectly done Fix causing multiple operations to sometimes be incorrectly executed Jul 25, 2019
@jbaxleyiii jbaxleyiii merged commit 7660727 into master Jul 25, 2019
abernix added a commit that referenced this pull request Jul 25, 2019
@abernix abernix deleted the jackson/fix-operationName-bug branch February 25, 2020 21:03
abernix pushed a commit to apollographql/federation that referenced this pull request Sep 4, 2020
…l/jackson/fix-operationName-bug

Fix causing multiple operations to sometimes be incorrectly executed
Apollo-Orig-Commit-AS: apollographql/apollo-server@7660727
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants