types: Add @types/aws-lambda as a dependency of apollo-server-lambda.
#3242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…da`. The typings provided by `aws-types` are used on public methods within the `apollo-server-express` package and, therefore, must be included as direct (not development) dependencies to ensure they are available to packages which utilize it since we don't publish types separately (e.g. via DefinitelyTyped). For example, these usages: https://github.com/apollographql/apollo-server/blob/aa3e23de9fbcde41a1bd3cca9c2eacf734bae582/packages/apollo-server-lambda/src/lambdaApollo.ts#L16-L18 https://github.com/apollographql/apollo-server/blob/aa3e23de9fbcde41a1bd3cca9c2eacf734bae582/packages/apollo-server-lambda/src/ApolloServer.ts#L100-L104 And seen in the emitted type declarations here: https://unpkg.com/apollo-server-lambda@2.9.0/dist/ApolloServer.d.ts https://unpkg.com/apollo-server-lambda@2.9.0/dist/lambdaApollo.d.ts (Note the `import` statements, which must be resolvable by TypeScript!) Fixes: #2351
abernix
deleted the
abernix/add-aws-lambda-typings-to-apollo-server-lambda
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typings provided by
aws-typesare used on public methods within theapollo-server-expresspackage and, therefore, must be included as direct (not development) dependencies to ensure they are available to packages which utilize it since we don't publish types separately (e.g. via DefinitelyTyped).For example, these usages:
apollo-server/packages/apollo-server-lambda/src/lambdaApollo.ts
Lines 16 to 18 in aa3e23d
apollo-server/packages/apollo-server-lambda/src/ApolloServer.ts
Lines 100 to 104 in aa3e23d
And seen in the emitted type declarations here:
https://unpkg.com/apollo-server-lambda@2.9.0/dist/ApolloServer.d.ts
https://unpkg.com/apollo-server-lambda@2.9.0/dist/lambdaApollo.d.ts
(Note the
importstatements, which must be resolvable by TypeScript!)Fixes: #2351