Fix debug query plan logging #3376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug where query plan logging only occurred if `shouldShowQueryPlan` was true. This boolean is only true under certain conditions during _introspection only_, meaning that this debug log was disabled for all regular queries.
trevor-scheer
added a commit
that referenced
this pull request
Oct 16, 2019
This commit revisits recent changes from PR #3376 which broke Playground's ability to detect support for the Query Plan view. Playground's internals decide that QP is supported based on the response from the first introspection query. The previously mentioned PR broke this by not providing any response.extensions.__queryPlanExperimental at all. This makes sense for debug mode, but Playground still needs some form of hint to know that it's supported and continue sending the Apollo-Query-Plan-Experimental header.
trevor-scheer
added a commit
that referenced
this pull request
Oct 17, 2019
This commit revisits recent changes from PR #3376 which broke Playground's ability to detect support for the Query Plan view. Playground's internals decide that QP is supported based on the response from the first introspection query. The previously mentioned PR broke this by not providing any response.extensions.__queryPlanExperimental at all. This makes sense for debug mode, but Playground still needs some form of hint to know that it's supported and continue sending the Apollo-Query-Plan-Experimental header.
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
This commit fixes a bug where query plan logging only occurred if `shouldShowQueryPlan` was true. This boolean is only true under certain conditions during _introspection only_, meaning that this debug log was disabled for all regular queries. Apollo-Orig-Commit-AS: apollographql/apollo-server@44d7633
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…#3418) This commit revisits recent changes from PR apollographql/apollo-server#3376 which broke Playground's ability to detect support for the Query Plan view. Playground's internals decide that QP is supported based on the response from the first introspection query. The previously mentioned PR broke this by not providing any response.extensions.__queryPlanExperimental at all. This makes sense for debug mode, but Playground still needs some form of hint to know that it's supported and continue sending the Apollo-Query-Plan-Experimental header. Apollo-Orig-Commit-AS: apollographql/apollo-server@7abbb94
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where query plan logging only occurred
if
shouldShowQueryPlanwas true. This boolean is only trueunder certain conditions during introspection, meaning that
this debug log was disabled for all regular queries.
This PR opts to only serialize the query plan if either debugging is enabled, or if the
Apollo-Query-Plan-Experimentalheader is set. We then log and/or respond with the query plan as appropriate.