fix: report APQ hit/registration when sendHeaders is disabled.
#3986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This APQ flag reporting was almost surely changed incorrectly in #2931 and not caught during review, causing this APQ boolean to not be properly set when the request was, in fact, an APQ request, unless `sendHeaders` was enabled - which it is _not_ by default after the change that released it. Ref: https://github.com/apollographql/apollo-server/pull/2931/files#diff-24ae042112f9dcc18543ac851c4d8f7cR97-R102
glasser
approved these changes
Apr 15, 2020
There was a problem hiding this comment.
This actually dates back to the initial implementation of setting those fields (in an unreviewed commit by me in a since-deleted repository). I am pretty sure your fix is correct, but update the message to not incorrectly point fingers at yourself and Helen :)
abernix
deleted the
abernix/fix-apq-hit-registration-sendHeaders-disabled
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This APQ flag reporting was almost surely a mistake from the past, causing this APQ boolean to not be properly set when the request was, in fact, an APQ request, unless
sendHeaderswas enabled - which it is not by default after the change that released it.Ref: https://github.com/apollographql/apollo-server/pull/2931/files#diff-24ae042112f9dcc18543ac851c4d8f7cR97-R102
TODO
CHANGELOG.md