Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache control: don't apply default max age until after resolver runs #5492

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

glasser
Copy link
Member

@glasser glasser commented Jul 16, 2021

This also gives resolvers the ability to differentiate between a
maxAge that was explicitly set but happens to equal the default
maxAge and one that was not explicitly set.

Fixes #5488. Helpful for apollographql/federation#870.

@glasser glasser requested a review from abernix July 16, 2021 06:40
This also gives resolvers the ability to differentiate between a
`maxAge` that was explicitly set but happens to equal the default
`maxAge` and one that was not explicitly set.

Fixes #5488. Helpful for apollo/federation#870.
@glasser glasser force-pushed the glasser/cache-default-dynamic-restrict branch from 38a6221 to f1c1732 Compare July 16, 2021 06:40
@hwillson hwillson added this to the MM-2021-07 milestone Jul 16, 2021
@glasser glasser merged commit 70f5515 into main Jul 16, 2021
@glasser glasser deleted the glasser/cache-default-dynamic-restrict branch July 16, 2021 16:35
@glasser
Copy link
Member Author

glasser commented Jul 16, 2021

Fix released in 3.0.1.

@hwillson hwillson removed this from the MM-2021-07 milestone Jul 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cache control: defaultMaxAge shouldn't be applied if you use dynamic cache control
3 participants