Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin node-abort-controller #7331

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Conversation

trevor-scheer
Copy link
Member

Original issue resolved via southpolesteve/node-abort-controller#40 and breaking change undone as of v3.1.1

@netlify
Copy link

netlify bot commented Jan 26, 2023

Deploy Preview for apollo-server-docs ready!

Name Link
🔨 Latest commit db5ea0d
🔍 Latest deploy log https://app.netlify.com/sites/apollo-server-docs/deploys/63d2af86a173a90009763900
😎 Deploy Preview https://deploy-preview-7331--apollo-server-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit db5ea0d:

Sandbox Source
Apollo Server Typescript Configuration
Apollo Server Configuration

@trevor-scheer trevor-scheer merged commit 9de18b3 into main Jan 26, 2023
@trevor-scheer trevor-scheer deleted the trevor/unpin-node-abort-controller branch January 26, 2023 18:16
trevor-scheer pushed a commit that referenced this pull request Feb 6, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @apollo/server-integration-testsuite@4.3.3

### Patch Changes

- [#7338](#7338)
[`01bc39838`](01bc398)
Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Update
graphql-http to 1.13.0

- Updated dependencies
\[[`9de18b34c`](9de18b3),
[`8c635d104`](8c635d1)]:
    -   @apollo/server@4.3.3

## @apollo/server@4.3.3

### Patch Changes

- [#7331](#7331)
[`9de18b34c`](9de18b3)
Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Unpin
`node-abort-controller` and update to latest unbreaking patch

- [#7136](#7136)
[`8c635d104`](8c635d1)
Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Errors
reported by subgraphs (with no trace data in the response) are now
accurately reflected in the numeric error stats.

Operations that receive errors from subgraphs (with no trace data in the
response) are no longer sent as incomplete, error-less traces.

Note: in order for this fix to take effect, your `@apollo/gateway`
version must be updated to v2.3.1 or later.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants