FIX: Incorrect Content-Type for apollo-server-adonis #910
Conversation
| @@ -35,7 +35,8 @@ export function graphqlAdonis( | |||
| query, | |||
| }).then( | |||
| gqlResponse => { | |||
| response.json(gqlResponse); | |||
| response.header('Content-Type', 'application/json'); | |||
There was a problem hiding this comment.
Not familiar with Adonis patterns but, aside from being more concise, is there a benefit to using the response.type('application/json') technique (outlined in the docs here) as opposed to this more explicit response.header?
(Keep in mind that we've never supported Adonis 3.0, so the fact that it isn't present in v3 docs shouldn't matter.)
CaptainJojo
force-pushed
the
fix/incorrect-response-apollo-server-adonis
branch
2 times, most recently
from
2d3e65b
to
d2e5947
Compare
CaptainJojo
force-pushed
the
fix/incorrect-response-apollo-server-adonis
branch
from
110c3a3
to
8a5f3ad
Compare
|
Thank a lot @abernix, I change for |
CaptainJojo
force-pushed
the
fix/incorrect-response-apollo-server-adonis
branch
from
8a5f3ad
to
efc3377
Compare
| @@ -35,7 +35,8 @@ export function graphqlAdonis( | |||
| query, | |||
| }).then( | |||
| gqlResponse => { | |||
| response.json(gqlResponse); | |||
| response.type('application/json'); | |||
There was a problem hiding this comment.
Thanks for tweaking that, @CaptainJojo.
One last question: Do you know if the Content-length is set automatically, or should we set it like we do for express? If it's not set, it would be beneficial for it to be there!
There was a problem hiding this comment.
I think is set automatically, they are not option in adonis :)
|
This should be published in |
#Issue #867
Intended outcome
Responses from apollo-server-adonis shall have a Content-Type: application/json header set.
Actual outcome
Responses have Content-Type: text/plain; charset=utf-8 header set.
Analysis
The module apollo-server-adonis calls response.json(gqlResponse) after it gets the output from runHttpQuery.
However, gqlResponse is already stringified (see link 1). The only reason .json method works, is because it is an "alias" to .send and uses heuristics to determine the content type in the end, regardless of the response method used. Adonis has it's own response object, with a similar interface to Express but a different implementation.
Proposed Solutions
Continue returning gqlResponse as-is, but use send method and manually set the content type header to application/json. The easiest to implement.