Convert Buffer.byteLength
to string before assigning to Content-Length
.
#956
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change seems necessary in order to meet the new type definitions for
res.setHeader
which mandate that the argument be a string, or an array ofstrings. Those type definitions were introduced via the
@types/node@9
series of typing updates provided in (0), (1), (2).
With any luck, this will fix the failures being exhibited in CircleCI
tests (3) after we landed those typing updates.