-
Notifications
You must be signed in to change notification settings - Fork 468
-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom validation rules in apollo-language-server #1056
Labels
🔨 cli
related to the CLI itself
🗒️ component - vscode
related to editor tooling
🎉 feature
New addition or enhancement to existing solutions
Comments
JakeDawkins
added
🔨 cli
related to the CLI itself
🎉 feature
New addition or enhancement to existing solutions
🗒️ component - vscode
related to editor tooling
discussion ☕
labels
Feb 26, 2019
alloy
added a commit
to alloy/apollo-tooling
that referenced
this issue
May 21, 2019
alloy
added a commit
to alloy/apollo-tooling
that referenced
this issue
May 21, 2019
alloy
added a commit
to alloy/apollo-tooling
that referenced
this issue
May 21, 2019
alloy
added a commit
to alloy/apollo-tooling
that referenced
this issue
May 21, 2019
Created a new PR #1288 |
alloy
added a commit
to alloy/apollo-tooling
that referenced
this issue
May 23, 2019
alloy
added a commit
to alloy/apollo-tooling
that referenced
this issue
May 24, 2019
trevor-scheer
pushed a commit
that referenced
this issue
May 30, 2019
* [language server] Allow configuration of validation rules. * [language server] Allow filtering of default validation rules Closes #1056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🔨 cli
related to the CLI itself
🗒️ component - vscode
related to editor tooling
🎉 feature
New addition or enhancement to existing solutions
Inspired by #800
Right now, the
apollo-language-server
runs a set of validation rules against operations (great, right??).In certain circumstances (like if you're running a relay project), you may want to disable existing validations or add new ones (like requiring an
id
on every object type for caches).Since the
apollo.config.js
is an executable file, not just a static configuration, we can actually add these validations to it to run against client projects!Here's my proposed API:
This way, you'd have full control (for better or worse 😉) over validation rules, rather than just enabling/disabling rules from graphql-js
This would require changes to:
The text was updated successfully, but these errors were encountered: