Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(q-p-w): Be explicit about the files and rm wasm-pack artifacts. #557

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

abernix
Copy link
Member

@abernix abernix commented Mar 10, 2021

Following up on #270, this ensures that the correct files are included in the published @apollo/query-planner-wasm package.

Debugging this was frustrating, as npm has some particular rules about how it includes files and when it respects .gitignore vs .npmignore vs. the presence of both, but I'll point out that the suggestion to run npx npm-packlist provided at this URL was quite helpful.

Other references, which I've certainly read many times but still come in handy:

@abernix abernix enabled auto-merge (squash) March 10, 2021 11:22
@abernix abernix disabled auto-merge March 10, 2021 11:23
@abernix abernix merged commit d224dd6 into main Mar 10, 2021
@abernix abernix deleted the abernix/query-planner-wasm-follow-up branch March 10, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant