Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pkg): build esm and cjs mods #270

Merged
merged 3 commits into from
Mar 10, 2021
Merged

feat(pkg): build esm and cjs mods #270

merged 3 commits into from
Mar 10, 2021

Conversation

ashleygwilliams
Copy link
Contributor

@ashleygwilliams ashleygwilliams commented Nov 2, 2020

fixes #255

this PR introduces a new build script that builds an ESM version of the wasm-query planner alongside the existing CJS/node version. this should improve folks' experience bundling this project for targets that expect this type of structure.

@ashleygwilliams ashleygwilliams changed the title [WIP] feat(pkg): build esm and cjs mods feat(pkg): build esm and cjs mods Nov 5, 2020
Also introduces a CHANGELOG.md for the `@apollo/query-planner-wasm` package.
@abernix abernix merged commit 20181dd into main Mar 10, 2021
@abernix abernix deleted the wasm-pkg branch March 10, 2021 07:53
@abernix
Copy link
Member

abernix commented Mar 10, 2021

I've added added a CHANGELOG.md entry in both @apollo/query-planner-wasm's CHANGELOG.md and a corresponding entry in the CHANGELOG.md for @apollo/gateway reflecting the dependency update and we'll get this out in to a release soon. Thanks for this, and sorry it took so long to get it out! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to bundle query-planner-wasm dependecy for use on lambdas
2 participants