Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle variable parse error #131

Merged
merged 18 commits into from
Sep 10, 2016
Merged

Handle variable parse error #131

merged 18 commits into from
Sep 10, 2016

Conversation

nnance
Copy link
Contributor

@nnance nnance commented Sep 9, 2016 •
edited
Loading

This fixes #130

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@nnance
convert hapi plugin classes to functions
3b64f0e
@nnance
improve handler
2b62006
@nnance
create Hapi plugin options
e456c7c
@nnance
Merge branch 'master' of github.com:apollostack/apollo-server into ap…
018ca70 
…ollo-hapi

# Conflicts:
#	src/integrations/hapiApollo.ts
@nnance
basic requests working
9af6106
@nnance
improve error handling
3c9add1
@nnance
working batch query
3a73fcc
@nnance
add route config options
f820d97
@nnance
Merge branch 'master' of github.com:apollostack/apollo-server into ap…
d6a5177 
…ollo-hapi

# Conflicts:
#	src/integrations/hapiApollo.ts
@nnance
improve HAPIGraphiQL api
a96f578
@nnance
update documentation
0fd39f2
@nnance
minor doc updates
f75f5b6
@nnance
fix readme example
8e983b4
@nnance
minor doc update
c2fd567
@nnance
error handling for parsing query variables
5b85422
@nnance
Merge branch 'master' of github.com:apollostack/apollo-server into pa…
ea0a7dd 
…rse-variables
@nnance nnance added this to the 0.3 milestone Sep 9, 2016
@nnance
Copy link
Contributor Author

nnance commented Sep 9, 2016

@helfer don't look at the commits this was built on top of the hapi-refactor branch. It's ready to be merged if you agree

@nnance nnance merged commit 00394c6 into master Sep 10, 2016
@nnance nnance deleted the parse-variables branch September 10, 2016 01:30
@zol zol removed the ready label Sep 10, 2016
trevor-scheer pushed a commit that referenced this pull request May 6, 2020
@renovate @abernix
chore(deps): update dependency typescript to v3.5.3 (#131)
38b83e7
trevor-scheer pushed a commit that referenced this pull request May 14, 2020
@renovate @abernix
chore(deps): update dependency typescript to v3.5.3 (#131)
733f27e
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3
Development

Successfully merging this pull request may close these issues.

Fix error handling when parsing variables parameter
2 participants
@nnance @zol