initial design document for apollo server #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nnance Let me know if you have any thoughts on the design document. I'll leave the PR open for a bit, in case others want to provide feedback as well. |
| @@ -0,0 +1,37 @@ | |||
| # Apollo Server design goals | |||
|
|
|||
| The goal of this project is to build a GraphQL server for Node.js that is simple, flexible, and performant. It is a Node.js GraphQL server built for production use. | |||
There was a problem hiding this comment.
The second sentence seems unnecessary.
There was a problem hiding this comment.
Actually for us that is a very important point. We need a production viable Graphql server. To this point if problems are found in the Graphql js reference implementation will the Apollo server either have its own fork or its own implementation?
There was a problem hiding this comment.
@nnance If there are issues in graphql-js that we need to be fixed right away, I think we would fork graphql-js and use our fork in apollo server until the PR lands in graphql-js. If possible I'd like to avoid maintaining a fork forever. If there is no way around maintaining a fork, it should be a community effort for a production-optimized version of graphql in js, and not something only apollo server uses.
helfer
added a commit
that referenced
this pull request
Jul 5, 2016
* initial design document for apollo server * update DESIGN.md to clarify some things
trevor-scheer
pushed a commit
that referenced
this pull request
May 6, 2020
This PR contains the following updates: | Package | Type | Update | Change | References | |---|---|---|---|---| | jest-junit | devDependencies | major | `5.2.0` -> `6.3.0` | [source](https://togithub.com/jest-community/jest-junit) | --- ### Release Notes <details> <summary>jest-community/jest-junit</summary> ### [`v6.3.0`](https://togithub.com/jest-community/jest-junit/releases/v6.3.0) [Compare Source](https://togithub.com/jest-community/jest-junit/compare/v6.2.1...v6.3.0) Conditional boolean configuration to add the FILE attribute for Circle-CI builds [#​77](https://togithub.com/jest-community/jest-junit/pull/77) ### [`v6.2.1`](https://togithub.com/jest-community/jest-junit/releases/v6.2.1) [Compare Source](https://togithub.com/jest-community/jest-junit/compare/v6.2.0...v6.2.1) Fix syntax error when running on some versions of node 6.0 ### [`v6.2.0`](https://togithub.com/jest-community/jest-junit/releases/v6.2.0) [Compare Source](https://togithub.com/jest-community/jest-junit/compare/v6.1.0...v6.2.0) Removes jest-config dependency ### [`v6.1.0`](https://togithub.com/jest-community/jest-junit/releases/v6.1.0) [Compare Source](https://togithub.com/jest-community/jest-junit/compare/v6.0.1...v6.1.0) Adds XML prologue to generated junit files [#​72](https://togithub.com/jest-community/jest-junit/pull/72) ### [`v6.0.1`](https://togithub.com/jest-community/jest-junit/releases/v6.0.1) [Compare Source](https://togithub.com/jest-community/jest-junit/compare/v6.0.0...v6.0.1) Roll back "file" attribute change to TestCase. This breaks on Jenkins. ### [`v6.0.0`](https://togithub.com/jest-community/jest-junit/releases/v6.0.0) [Compare Source](https://togithub.com/jest-community/jest-junit/compare/v5.2.0...v6.0.0) Add file attribute to TestCase elements for better viewability on CI platforms. [#​71](https://togithub.com/jest-community/jest-junit/pull/71) Use relative file paths instead of absolute for better resolution on CI platforms. [#​70](https://togithub.com/jest-community/jest-junit/pull/70) </details> --- ### Renovate configuration :date: **Schedule**: "after 6pm every weekday,before 5am every weekday" in timezone America/Los_Angeles. :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is stale, or if you modify the PR title to begin with "`rebase!`". :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#apollographql/apollo-platform-commercial).
trevor-scheer
pushed a commit
that referenced
this pull request
May 14, 2020
This PR contains the following updates: | Package | Type | Update | Change | References | |---|---|---|---|---| | jest-junit | devDependencies | major | `5.2.0` -> `6.3.0` | [source](https://togithub.com/jest-community/jest-junit) | --- ### Release Notes <details> <summary>jest-community/jest-junit</summary> ### [`v6.3.0`](https://togithub.com/jest-community/jest-junit/releases/v6.3.0) [Compare Source](https://togithub.com/jest-community/jest-junit/compare/v6.2.1...v6.3.0) Conditional boolean configuration to add the FILE attribute for Circle-CI builds [#​77](https://togithub.com/jest-community/jest-junit/pull/77) ### [`v6.2.1`](https://togithub.com/jest-community/jest-junit/releases/v6.2.1) [Compare Source](https://togithub.com/jest-community/jest-junit/compare/v6.2.0...v6.2.1) Fix syntax error when running on some versions of node 6.0 ### [`v6.2.0`](https://togithub.com/jest-community/jest-junit/releases/v6.2.0) [Compare Source](https://togithub.com/jest-community/jest-junit/compare/v6.1.0...v6.2.0) Removes jest-config dependency ### [`v6.1.0`](https://togithub.com/jest-community/jest-junit/releases/v6.1.0) [Compare Source](https://togithub.com/jest-community/jest-junit/compare/v6.0.1...v6.1.0) Adds XML prologue to generated junit files [#​72](https://togithub.com/jest-community/jest-junit/pull/72) ### [`v6.0.1`](https://togithub.com/jest-community/jest-junit/releases/v6.0.1) [Compare Source](https://togithub.com/jest-community/jest-junit/compare/v6.0.0...v6.0.1) Roll back "file" attribute change to TestCase. This breaks on Jenkins. ### [`v6.0.0`](https://togithub.com/jest-community/jest-junit/releases/v6.0.0) [Compare Source](https://togithub.com/jest-community/jest-junit/compare/v5.2.0...v6.0.0) Add file attribute to TestCase elements for better viewability on CI platforms. [#​71](https://togithub.com/jest-community/jest-junit/pull/71) Use relative file paths instead of absolute for better resolution on CI platforms. [#​70](https://togithub.com/jest-community/jest-junit/pull/70) </details> --- ### Renovate configuration :date: **Schedule**: "after 6pm every weekday,before 5am every weekday" in timezone America/Los_Angeles. :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is stale, or if you modify the PR title to begin with "`rebase!`". :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#apollographql/apollo-platform-commercial).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #2