Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make a separate tracing structure for Studio reporting #795

Closed
Geal opened this issue Apr 5, 2022 · 3 comments · Fixed by #898
Closed

make a separate tracing structure for Studio reporting #795

Geal opened this issue Apr 5, 2022 · 3 comments · Fixed by #898
Assignees

Comments

@Geal
Copy link
Contributor

Geal commented Apr 5, 2022

currently the query execution trace is generated using tracing spans. While the tracing infra is designed for that kind of use case, right now it is unreliable because it collides with other concerns like opentelemetry:

  • opentelemetry sampling affects studio traces, some of them are not sent
  • log level filters affect studio traces, we need to set INFO on apollo-router and apollo-route-core, otherwise they are not sent
  • adding the graphql query to the root span's variables pollutes the logs in CLI

We should instead have a separate, smaller span structure that is activated or not depending on studio reporting, and entirely (except the root span created in the HTTP server) manipulated in the query planner execution

@Geal Geal added the triage label Apr 5, 2022
@bnjjj
Copy link
Contributor

bnjjj commented Apr 5, 2022

Also related to #790 I think

@BrynCooke
Copy link
Contributor

Can we use the otel metrics infra rather than tracing for this? Metrics are never sampled and the data feels like a metrics thing rather than a tracing thing.

@BrynCooke BrynCooke linked a pull request May 9, 2022 that will close this issue
@nateql
Copy link

nateql commented May 9, 2022

Closing this ticket since it is closed on the project board.

@nateql nateql closed this as completed May 9, 2022
@Geal Geal added this to the v0.9.0-rc.0 milestone May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants