Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all references to router to Apollo Router #117

Merged
merged 6 commits into from
Nov 10, 2021
Merged

Conversation

BrynCooke
Copy link
Contributor

Rename all references to router to Apollo Router
Remove the in most cases when preceding Apollo Router

Remove `the` in most cases when preceding `Apollo Router`
@netlify
Copy link

netlify bot commented Nov 10, 2021

❌ Deploy Preview for apollo-router-docs failed.

🔨 Explore the source changes: d844d02

🔍 Inspect the deploy log: https://app.netlify.com/sites/apollo-router-docs/deploys/618bc99f1238240007b4f201

bryn added 2 commits November 10, 2021 14:38
Re-add `the` where is makes sense to
Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small points within, but LGTM!

README.md Outdated Show resolved Hide resolved
docs/source/build-from-source.mdx Outdated Show resolved Hide resolved
docs/source/quickstart.mdx Outdated Show resolved Hide resolved
BrynCooke and others added 3 commits November 10, 2021 15:01
Co-authored-by: Jesse Rosenberger <git@jro.cc>
Co-authored-by: Jesse Rosenberger <git@jro.cc>
Co-authored-by: Jesse Rosenberger <git@jro.cc>
@BrynCooke BrynCooke merged commit d45e422 into main Nov 10, 2021
@BrynCooke BrynCooke deleted the router-naming branch November 10, 2021 14:16
@abernix abernix mentioned this pull request Nov 19, 2021
@BrynCooke BrynCooke self-assigned this Mar 25, 2022
tinnou pushed a commit to Netflix-Skunkworks/router that referenced this pull request Oct 16, 2023
…ry-planner-inaccessible

bump query-planner to 2.0.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants