Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release: v1.45.1 #5009

Merged
merged 11 commits into from
Apr 26, 2024
Merged

release: v1.45.1 #5009

merged 11 commits into from
Apr 26, 2024

Conversation

abernix
Copy link
Member

@abernix abernix commented Apr 24, 2024

Note
This particular PR must be true-merged to main.

  • This PR is only ready to review when it is marked as "Ready for Review". It represents the merge to the main branch of an upcoming release (version number in the title).
  • It will act as a staging branch until we are ready to finalize the release.
  • We may cut any number of alpha and release candidate (RC) versions off this branch prior to formalizing it.
  • This PR is primarily a merge commit, so reviewing every individual commit shown below is not necessary since those have been reviewed in their own PR. However, things important to review on this PR once it's marked "Ready for Review":
    • Does this PR target the right branch? (usually, main)
    • Are the appropriate version bumps and release note edits in the end of the commit list (or within the last few commits). In other words, "Did the 'release prep' PR actually land on this branch?"
    • If those things look good, this PR is good to merge!

@router-perf
Copy link

router-perf bot commented Apr 24, 2024

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • large-request - Stress test with a 1 MB request payload
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • xxlarge-request - Stress test with 100 MB request payload
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • xlarge-request - Stress test with 10 MB request payload
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • no-graphos - Basic stress test, no GraphOS.
  • reload - Reload test over a long period of time at a constant rate of users
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • const - Basic stress test that runs with a constant number of users

garypen and others added 3 commits April 24, 2024 16:19
@garypen
Use subgraph.name attribute not apollo.subgraph.name (#5012)
8cb47dd 
The DD exporter does some explicit mapping of attributes and was using a
value "apollo.subgraph.name" that the latest versions of the router
don't use. The correct choice is "subgraph.name".

Update the mapping to reflect this change.
@Geal
Use the entire schema when hashing an introspection query (#5007)
062ff03 
Fix #5006

in #4883 we introduced a
query hashing scheme that stays stable across schema updates if the
update does not affect the query. Unfortunately, it was not taking
introspection queries into account.
This fixes the hashing mechanism to add the schema string to hashed data
if we encounter an introspection field. This is a temporary fix until we
move introspection execution out of query planning. At that point, this
hashing mechanism won't ever see introspection fields.
@abernix
prep release: v1.45.1-rc.0
a38c99f
@abernix abernix mentioned this pull request Apr 26, 2024
Closed
abernix and others added 7 commits April 26, 2024 15:13
@abernix
tests: Remove "is proto fresh" test in lieu of GitHub Action (#5031)
036eb25 
We'll have a GitHub Action do the maintenance on this file, rather than
having a test remind us that it's stale. The test results in all PRs
(and
all downstream users of this repository) suddenly getting failing tests
every time our infra-team deploys a new version of the proto, whereas
the
GitHub Action can be a much more controlled burn.

The GitHub action that replaces this is in [#5030], and we will merge
this test just as soon as that is validated.

[#5030]: #5030
@abernix @shorgi
Update .changesets/fix_geal_schema_aware_hash_introspection.md
6d78077 
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
@abernix @shorgi
Update .changesets/fix_garypen_router_236_dd_mapping.md
0d90c93 
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
@abernix
chore/nit: Fix warnings and trailing newlines in CircleCI Config (#5033)
2774265 
In practice, this file actually serves as a cache key for our
configuration due to the incorporation of the file's hash in the
[key/ID], which I need to bump in order to rotate the cache in CircleCI.
While I'm here, I might as well fix the editor warnings being emitted
about this not being a valid version of Xcode, along with some trailing
newlines! While we had '14.2' as the value to bring in patch releases of
Xcode, I'd rather we not have that level of indeterminism anyhow, so
I'll just make it '14.2.0' which is the latest '14.2' release anyhow.

[key/ID]:
https://github.com/apollographql/router/blob/0137e0cf848b9b22ef94fe14b32ed1a082d3f0b5/.circleci/config.yml#L73-L83
@o0Ignition0o @abernix @glasser
use the full operation and schema to generate query key hashes (#5028)
b2edc75 
Co-authored-by: Jesse Rosenberger <git@jro.cc>
Co-authored-by: David Glasser <glasser@davidglasser.net>
@abernix
prep release: v1.45.1-rc.1
315aaee
@abernix
prep release: v1.45.1
167af00
@abernix abernix marked this pull request as ready for review April 26, 2024 20:48
@abernix abernix requested a review from a team as a code owner April 26, 2024 20:48
@abernix abernix merged commit ff9f666 into main Apr 26, 2024
6 of 7 checks passed
@abernix abernix deleted the 1.45.1 branch April 26, 2024 20:52
@abernix abernix restored the 1.45.1 branch April 26, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shorgi shorgi shorgi left review comments

@AlexanderMann AlexanderMann AlexanderMann approved these changes

@IvanGoncharov IvanGoncharov IvanGoncharov approved these changes

Assignees

@abernix abernix

Labels
release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@abernix @AlexanderMann @IvanGoncharov @shorgi @garypen @Geal @o0Ignition0o