chore(maint,1.45.1): Update code and snapshots after proto update #5029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DD exporter does some explicit mapping of attributes and was using a value "apollo.subgraph.name" that the latest versions of the router don't use. The correct choice is "subgraph.name". Update the mapping to reflect this change.
Fix #5006 in #4883 we introduced a query hashing scheme that stays stable across schema updates if the update does not affect the query. Unfortunately, it was not taking introspection queries into account. This fixes the hashing mechanism to add the schema string to hashed data if we encounter an introspection field. This is a temporary fix until we move introspection execution out of query planning. At that point, this hashing mechanism won't ever see introspection fields.
|
CI performance tests
|
abernix
changed the title
abernix
changed the title
abernix
changed the title
We'll have a GitHub Action do the maintenance on this file, rather than having a test remind us that it's stale. The test results in all PRs (and all downstream users of this repository) suddenly getting failing tests every time our infra-team deploys a new version of the proto, whereas the GitHub Action can be a much more controlled burn. The GitHub action that replaces this is in [#5030], and we will merge this test just as soon as that is validated. [#5030]: #5030
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
In practice, this file actually serves as a cache key for our configuration due to the incorporation of the file's hash in the [key/ID], which I need to bump in order to rotate the cache in CircleCI. While I'm here, I might as well fix the editor warnings being emitted about this not being a valid version of Xcode, along with some trailing newlines! While we had '14.2' as the value to bring in patch releases of Xcode, I'd rather we not have that level of indeterminism anyhow, so I'll just make it '14.2.0' which is the latest '14.2' release anyhow. [key/ID]: https://github.com/apollographql/router/blob/0137e0cf848b9b22ef94fe14b32ed1a082d3f0b5/.circleci/config.yml#L73-L83
|
I don't think this is necessary any longer since 1.45.1 has landed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-apply #5026 on #5009. While this doesn't currently work on
devin the original PR, this looks like it passes on this branch and would free up the 1.45.1 branch for release.