-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gt and lt operators for telemetry conditions #5048
Conversation
This comment has been minimized.
This comment has been minimized.
CI performance tests
|
@tninesling Could you do this on top of #5022 to also add support for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…by combinations of gt and existing conditions; simplify API so gt takes a list in yaml like eq
… range will still be up to the user via combinations of existing operators
<!-- ROUTER-237 --> | ||
--- | ||
|
||
**Checklist** | ||
|
||
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review. | ||
|
||
- [X] Changes are compatible[^1] | ||
- [ ] Documentation[^2] completed | ||
- [ ] Performance impact assessed and acceptable | ||
- Tests added and passing[^3] | ||
- [X] Unit Tests | ||
- [ ] Integration Tests | ||
- [ ] Manual Tests | ||
|
||
**Exceptions** | ||
|
||
*Note any exceptions here* | ||
|
||
**Notes** | ||
|
||
[^1]: It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. | ||
[^2]: Configuration is an important part of many changes. Where applicable please try to document configuration examples. | ||
[^3]: Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. | ||
|
||
By [@tninesling](https://github.com/tninesling) in https://github.com/apollographql/router/pull/5048 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Post merge note: this bit shouldn't be in the changelog. We'll remove in post on #5180.
Add gt, gte, lt, lte, and range operations for telemetry conditions.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩