release: v1.47.0 #5180
Merged
release: v1.47.0 #5180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sylvain Lebresne <lebresne@gmail.com> Co-authored-by: Dariusz Kuc <9501705+dariuszkuc@users.noreply.github.com> Co-authored-by: Sachin D. Shinde <sachin@apollographql.com> Co-authored-by: Gary Pennington <gary@apollographql.com> Co-authored-by: Coenen Benjamin <benjamin.coenen@hotmail.com> Co-authored-by: Renée <renee@kooi.me> Co-authored-by: Simon Sapin <simon.sapin@exyr.org>
## Motivation / Implements This PR updates the version of the SecOps orb used in this repo. Version 2.0.0 of the orb included an issue on the gitleaks job that prevented the job from running on PRs created from forks. The issue was caused by a default configuration in CircleCI which prevents providing secrets provided through CircleCI contexts to PRs created from forks. This default configuration is probably the correct one, so we needed up update the SecOps orb to properly operate on PRs from forks.
…/federation-next#63) Trigger CircleCI release job when new GH release (and associated tag) are created
Cargo doesnt support publishing multiple modules so we have to explicitly publish single module at a time. Updating publish job to `apollo-federation` working directory
…xt#56) Code for extracting subgraphs from supergraphs, and any other code in the `federation` repo that this code uses. A few things to note: - Despite naming, the function does not generally extract subgraphs from supergraphs, as composition at this time is not a fully reversible transformation. It extracts subgraph information for the purposes of query planning; other purposes may find this "extraction" lacking/insufficient. - This code is not directly called by router; it's one of the early parts of query planning. - This code aims to mimic the JS code where possible to ease understanding and maintenance burden, but if this leads to unacceptable Rust practices please let me know. - There are currently no tests; these will be added later.
apollographql/federation-next#67) To simplify publishing and building `federation-next`, this PR removes `apollo-harness` into its own repo - [`federation-performance-harness`](https://github.com/apollographql/federation-performance-harness)
Simplifying project structure.
This adds a CI job to ensure this repo can compile to wasm. Any change that doesn't work with wasm will then be flagged early.
Accidentally dropped it when doing the repo structure cleanup in apollographql/federation-next#68.....
…xt#79) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [secops](https://circleci.com/developer/orbs/orb/apollo/circleci-secops-orb) | orb | patch | `2.0.1` -> `2.0.2` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - "after 8am and before 4pm on tuesday" in timezone Etc/UTC. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNTkuNSIsInVwZGF0ZWRJblZlciI6IjM1LjE1OS41IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <svc-secops+renovate@apollographql.com>
Sylvain is no longer at Apollo, and I should probably be added to reviews.
…0-beta.6` (apollographql/federation-next#85) This PR exists mainly to unblock the rebasing of apollographql/federation-next#80 and apollographql/federation-next#84, as they'll have merge conflicts with the updated code (and I'd like to update the code for those PRs today). After I've finished rebasing those two PRs, will file a PR for 2nd half (probably later today).
….0-beta.6` (apollographql/federation-next#86) This PR is the second half of apollographql/federation-next#85 , and fully updates `federation-next` to work with `apollo-compiler@1.0.0-beta.6`. Some notes: - This is mainly replacing `&str` with `Name`, and converting some functions to use `Result`s. - The other notable changes are that types (e.g. `ObjectType`) need a `name` field now (making it consistent with the rest of the schema elements in `apollo-rs`), and some minor renames. - Clippy warns that since `NodeStr` doesn't have `#[derive(PartialEq, Eq)]`, then we can't use `Name` in pattern-matching; I've worked around it with an enum and map for now. - Consolidated a bit of the logic around converting subgraph names to enum values, with a `TODO` around doing what the JS codebase does. - Unrelated, but I've been told we had some usages of `.eq()` in the Rust code, so I've converted them to `==`.
…ation-next#80) This PR: - Updates the `federation-next` schema wrapper to handle reserved names better. Specifically, we now: - Error if we try to insert/remove elements containing fields/arguments/input fields/enum values that start with `__`. - Note that built-in shadowing is still TODO/isn't implemented here, so accordingly we still ignore built-in types/directives as before. - Allow fetching meta-fields for objects/interfaces/unions, via `apollo-rs`'s `Schema.type_field()` method. - We track their GraphQL references appropriately, similar to the JS code. - We also add some convenience functions to get child positions from parent positions, and update code to call them. - Rearrange GraphQL reference insertion to occur after `Schema` element insertion instead of before, as we need the type to already be in the schema to call `type_field()` during GraphQL reference insertion. This means doing map lookups post-element-insertion to get a Rust reference to the inserted element, though arguably inserting GraphQL references afterwards is saner behavior as we don't have to worry about the element not existing yet during GraphQL reference insertion. - Unrelated to the above, we also add some convenience structs/methods used by query graph creation here, namely: - `CompositeTypeDefinitionPosition`, `AbstractTypeDefinitionPosition`, and `FieldDefinitionPosition` (mainly just Rust enum analogues to the corresponding TS union types). - Some convenience methods for `Referencers` to handle map lookup errors.
…raphql/federation-next#84) This PR implements the intra-subgraph logic of federated query graph creation. That is, it implements the business logic that is performed for each individual subgraph when creating a federated query graph. The inter-subraph logic will be a separate PR, to keep PRs smaller. Tests will be added in follow-up PRs. Some notes: - Regarding porting, while the JS codebase creates a separate query graph for each subgraph and then copies its nodes/edges over to the federated one, the Rust code in this PR starts out with a single query graph (the federated one), and each builder adds its nodes/edges to that one. This allows us to avoid copying all the subgraph query graphs (and makes the porting/working with `petgraph` a bit easier). - We introduce a few convenience functions for `FederationSchema`/positions in this PR. We use those in the `QueryGraph` logic, but I've also refactored `extract_subgraphs_from_supergraph()` logic to use them, which has simplified some functions/removed lifetimes (also some bugfixes). - This PR is stacked on top of apollographql/federation-next#80 .
…deration-next#92) Release notes: https://github.com/apollographql/apollo-rs/releases/tag/apollo-compiler%401.0.0-beta.7 - Using the new `Type::parse` API in place of the workaround. it's still wrapped inside `decode_type` to convert the error type. - I didn't change `parse_keys` in composition yet even though `FieldSet::parse` does the right thing--the current code is written to only support a flat list of keys, not nested selection sets, so it needs some work to support that.
) This PR changes our integration test layout to generate a single binary, instead of having multiple (auto-discovered) binaries that are run serially. This mimics the [layout](https://github.com/apollographql/apollo-rs/blob/main/crates/apollo-compiler/Cargo.toml) of `apollo-compiler`. This is also the recommendation of [the docs](https://doc.rust-lang.org/cargo/reference/cargo-targets.html#integration-tests), to increase test parallelism when there are many tests/decrease how long it takes to run tests. For reviewers, use "Hide Whitespace" when reviewing (this PR only changes a few lines really).
abernix
reviewed
May 16, 2024
abernix
reviewed
May 16, 2024
.changesets/fix_strip_dashes_from_trace_id_in_customtraceidpropagator.md
Outdated
Show resolved
Hide resolved
abernix
reviewed
May 16, 2024
abernix
previously requested changes
May 16, 2024
I have a theory for the Federation version bump changeset (it was renamed), but I'm not sure why these existed in this PR.
abernix
dismissed
their stale review
I resolved them, but don't fully understand their re-introduction 52bbe1a
shorgi
reviewed
May 16, 2024
.changesets/fix_strip_dashes_from_trace_id_in_customtraceidpropagator.md
Outdated
Show resolved
Hide resolved
BrynCooke
reviewed
May 17, 2024
Co-authored-by: Bryn Cooke <BrynCooke@gmail.com> Co-authored-by: Edward Huang <edward.huang@apollographql.com>
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
Co-authored-by: Edward Huang <edward.huang@apollographql.com>
Co-authored-by: Coenen Benjamin <benjamin.coenen@hotmail.com>
garypen
approved these changes
May 21, 2024
o0Ignition0o
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainbranch of an upcoming release (version number in the title).main)