-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: return internal errors as structured error responses #5159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an http 500 is returned we should not return the details to the client. Instead, they are now logged.
This comment has been minimized.
This comment has been minimized.
CI performance tests
|
BrynCooke
changed the title
Prevent internal server error from leaking details to the client
Internal server error handling
May 13, 2024
Geal
approved these changes
May 14, 2024
that's a great idea |
bnjjj
reviewed
May 14, 2024
abernix
reviewed
May 14, 2024
abernix
reviewed
May 14, 2024
apollo-router/tests/integration/fixtures/broken_coprocessor.router.yaml
Outdated
Show resolved
Hide resolved
abernix
reviewed
May 14, 2024
...n/snapshots/integration_tests__integration__coprocessor__error_not_propagated_to_client.snap
Show resolved
Hide resolved
abernix
changed the title
Internal server error handling
fix: return internal errors as structured error responses
May 14, 2024
garypen
approved these changes
May 15, 2024
Co-authored-by: Jesse Rosenberger <git@jro.cc>
Merged
Geal
pushed a commit
that referenced
this pull request
Jun 10, 2024
Co-authored-by: bryn <bryn@apollographql.com> Co-authored-by: Jesse Rosenberger <git@jro.cc>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an http 500 is returned we should not return the details of the error to the client.
Instead, they are now logged at ERROR level.
In addition, the error is now returned as a graphql error rather than a plaintext error. This gives a better experience in sandbox.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩