fix: Cleanly shutdown the Telemetry plugin. #848
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #847 The telemetry plugin would cause the router to hang if ServiceBuilder::build() failed. This commit makes sure the Telemetry plugin is cleanly shutdown when it's the case, thus correctly erroring out instead of hanging.
o0Ignition0o
requested review from
garypen,
Geal and
BrynCooke
and removed request for
garypen and
Geal
✅ Deploy Preview for apollo-router-docs canceled.
|
o0Ignition0o
requested review from
Geal,
BrynCooke and
bnjjj
and removed request for
BrynCooke
garypen
approved these changes
Apr 13, 2022
BrynCooke
reviewed
Apr 13, 2022
| @@ -308,6 +309,20 @@ impl Plugin for Telemetry { | |||
| } | |||
| } | |||
|
|
|||
| impl Drop for Telemetry { | |||
| fn drop(&mut self) { | |||
| // This allows us to make sure the telemetry related globals | |||
There was a problem hiding this comment.
Gut feeling is that this will activate even if it was not supposed to, which would make this incorrect.
Let's talk this through.
BrynCooke
requested changes
Apr 13, 2022
|
Closing as #849 got merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #847
The telemetry plugin would cause the router to hang if ServiceBuilder::build() failed.
This commit makes sure the Telemetry plugin is cleanly shutdown when it's the case, thus correctly erroring out instead of hanging.