Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tool doesn't support OS level certificates #645

Closed
justinabrahms opened this issue Jun 30, 2021 · 4 comments · Fixed by #649
Closed

tool doesn't support OS level certificates #645

justinabrahms opened this issue Jun 30, 2021 · 4 comments · Fixed by #649
Labels

Comments

@justinabrahms
Copy link

Description

rover does not respect my OS level certificates.

Steps to reproduce

  1. Have an endpoint which uses certificates not signed by a central authority.
  2. Add the signer to your trust store.
  3. Make a request to it with rover graph introspect https://...

Expected result

You get the introspection results.

Actual result

You get a certificate error (but has a misleading error message due to #644)

Environment

Rover Info:
Version: 0.1.7
Install Location: /home/jabrahms/.rover/bin/rover
OS: Ubuntu 20.04 (focal) [64-bit]
Shell: /bin/bash

@justinabrahms justinabrahms added bug 🐞 triage issues and PRs that need to be triaged labels Jun 30, 2021
@EverlastingBugstopper
Copy link
Contributor

Ah - this was most likely introduced in #624. I switched our TLS backend to rustls since I wanted folks to be able to run rover on slim Docker images that usually don't come with ca-certificates preinstalled.

We can switch back to using the default TLS backend and it should resolve this issue, and we'll just document that you need ca-certificates installed to run Rover.

@justinabrahms
Copy link
Author

@EverlastingBugstopper Have you seen https://github.com/rustls/rustls-native-certs ? I saw when looking up this problem.

@EverlastingBugstopper
Copy link
Contributor

I did see that actually! Might try to go that route. I'll cc you on that when it happens and maybe you can try it out to make sure it works OK.

@justinabrahms
Copy link
Author

justinabrahms commented Jun 30, 2021 via email

This was referenced Jul 7, 2021
@abernix abernix removed the triage issues and PRs that need to be triaged label Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants