chore: simplify error formatting #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jesse Rosenberger <git@jro.cc>
Co-authored-by: Jesse Rosenberger <git@jro.cc>
- cleans up request errors by properly assigning codes and suggestions - local import for backoff crate - const the cfg!(test) check
EverlastingBugstopper
force-pushed
the
avery/better-error-formats
branch
from
ec44751
to
49411ef
Compare
EverlastingBugstopper
force-pushed
the
avery/configure-timeout
branch
from
6960c69
to
1bdf2f4
Compare
- fix suggestion indentation to 8 spaces instead of determining its length based on the length of the error descriptor - don't double-print reqwest::Error root causes
EverlastingBugstopper
force-pushed
the
avery/better-error-formats
branch
from
49411ef
to
f0e54c6
Compare
EverlastingBugstopper
requested a review
from StephenBarlow
as a code owner
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix suggestion indentation to 8 spaces instead of
determining its length based on the length of the error descriptor
don't double-print reqwest::Error root causes