Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom scalars fix #203

Merged
merged 4 commits into from Nov 23, 2016
Merged

Custom scalars fix #203

merged 4 commits into from Nov 23, 2016

Conversation

ghost
Copy link

@ghost ghost commented Nov 17, 2016

TODO:

  • Commit messages are formatted in a standard-version friendly way
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@ghost
Copy link
Author

ghost commented Nov 17, 2016

This PR is supposed to fix #197

Read carefuly and don't merge if you think something is wrong...

@stubailo
Copy link
Contributor

Hey, sorry - my mistake for not reviewing carefully enough before.

@dylang
Copy link

dylang commented Nov 22, 2016

Thanks for doing this work @oricordeau!

I can confirm this PR fixes the custom scalar issue for my code.

Looking forward to the merge.

@stubailo stubailo merged commit 12bc30a into ardatan:master Nov 23, 2016
@helfer helfer mentioned this pull request Nov 29, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stubailo @dylang @oricordeau