Respect return values of event handlers in jQuery.fn.onSafe #1670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jQuery.fn.onSafe would previously not pass the return value of event handlers to jQuery. That meant that even if the event handler would "return false;", event.stopPropagation and event.preventDefault would not be called. This came up as an issue for me after the recent merging of apostrophecms#1638, where I now had a set of .apos-buttons inside of an area, that was wrapped in an <a> element. Clicking the .apos-buttons would trigger a click on the link as well, and so the browser would navigate away from the page.
boutell
approved these changes
Oct 16, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jQuery.fn.onSafewould previously not pass the return value of event handlers to jQuery. That meant that even if the event handler wouldreturn false, event.stopPropagation and event.preventDefault would not be called.This came up as an issue for me after the recent merging of #1638, where I now had a set of .apos-buttons inside of an area, that was wrapped in an
<a>element. Clicking the .apos-buttons would trigger a click on the link as well, and so the browser would navigate away from the page.