Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Crash when entering malformed hour:minute duration #21

Closed
bbastin opened this issue Dec 3, 2020 · 1 comment
Closed

[Bug] Crash when entering malformed hour:minute duration #21

bbastin opened this issue Dec 3, 2020 · 1 comment

Comments

@bbastin
Copy link

bbastin commented Dec 3, 2020

Description of the bug
The App crashes when the duration is a malformed hour:minute string

To Reproduce
Steps to reproduce the behavior:

  1. Add new entry
  2. Select duration field
  3. Enter a malformed hour:minute duration like ”:30“ or ”1:“, or something non-numerical

Expected behavior
Either an error message or more lenient parsing which sets the hours/minutes to zero when they are missing or unparsable.

Additional information
App Version: 1.2.0
Android Version: 10

@apozas
Copy link
Owner

apozas commented Dec 4, 2020

Hi,

Thanks for letting me know. Well, that's what happens when you don't follow the indications 😝

Jokes aside, I tried to capture most "standard" mistakes when entering the form, and output a warning toast message. But as you have been able to check, these standard mistakes did not cover the cases you are mentioning.

The new version, 1.3.0, removes the duration field (see 537a4ea) in favor of a time of begin and time of end. This new version successfully built on F-Droid a few days ago, but for some reason I am not able to see it on the store yet. Hopefully, this will be solved in the next day or two.

Since this problem is solved (by making the duration disappear in v1.3.0), I'm closing the issue.

@apozas apozas closed this as completed Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants