Skip to content
This repository has been archived by the owner on Aug 14, 2020. It is now read-only.

Converting big images is slow #34

Closed
iaguis opened this issue Mar 24, 2015 · 2 comments · Fixed by #38
Closed

Converting big images is slow #34

iaguis opened this issue Mar 24, 2015 · 2 comments · Fixed by #38

Comments

@iaguis
Copy link
Member

iaguis commented Mar 24, 2015

I did some benchmarks with big images after #33 and the conversion is around 40% slower. This is so because we're compressing each layer and decompressing it when we squash to compress the squashed image again.

I think generating one ACI for each layer is a rather uncommon use case so compressing only the squashed image would be acceptable.

We could also consider using https://github.com/klauspost/pgzip to make it even faster.

@jonboulle
Copy link
Contributor

How about just compressing the squashed image unless people are explicitly requesting an ACI for each layer? Or maybe that's what you mean...

@iaguis
Copy link
Member Author

iaguis commented Mar 30, 2015

I wasn't meaning that but it makes total sense, silly me :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants