chore(android): migrate to gradle #44

garymathews · 2020-01-28T00:41:19Z

Migrate to gradle
Build using Titanium SDK 9.0.0
Update sqlcipher to version 4.3.0

appcelerator.encrypteddatabase-android-4.0.0.zip

jquick-axway

CR: Pass

sgtcoolguy · 2020-02-05T19:38:04Z

@garymathews Sorry for tossing a million commits onto your PR and force-pushing. I really wanted to get all the linting/tests/build stuff in before we cut new releases. I assume the only expected change at this point is the SDK version to use to build with the new xml namespace fix?

build · 2020-02-05T19:47:45Z

	Warnings
⚠️	SDK version declared in Jenkinsfile (9.0.0.v20200128095338) does not match iOS' titanium.xcconfig value (7.5.2.GA)

	Messages
📖	💾 Here are the artifacts produced: appcelerator.encrypteddatabase-android-4.0.0.zip appcelerator.encrypteddatabase-iphone-2.0.7.zip
📖	✅ All tests are passing Nice one! All 4 tests are passing.
📖	🎉 - congrats on your new release

Dependencies with modified semantic versioning:

@seadub/danger-plugin-junit - from ^0.1.0 to ^0.1.2
danger - from ^7.1.0 to ^9.2.10
eslint - from ^5.10.0 to ^6.8.0
eslint-config-axway - from ^4.1.1 to ^4.5.0
karma-titanium-launcher - from ^0.5.1 to ^0.7.5
socket.io - from ^2.2.0 to ^2.3.0

@commitlint/cli

Author: Mario Nebl

Description: Lint your commit messages

Homepage: https://github.com/conventional-changelog/commitlint#readme


Created	over 2 years ago
Last Updated	21 days ago
License	MIT
Maintainers	4
Releases	60
Direct Dependencies	`@commitlint/format`, `@commitlint/lint`, `@commitlint/load`, `@commitlint/read`, `babel-polyfill`, `chalk`, `get-stdin`, `lodash`, `meow`, `resolve-from` and `resolve-global`
Keywords	conventional-changelog, commitlint and cli

README

Lint commit messages

@commitlint/cli

Getting started

npm install --save-dev @commitlint/cli @commitlint/config-angular
echo "module.exports = {extends: ['@commitlint/config-angular']};" > commitlint.config.js

Consult docs/cli for comprehensive documentation.

@commitlint/config-conventional

Author: Mario Nebl

Description: Shareable commitlint config enforcing conventional commits

Homepage: https://github.com/conventional-changelog/commitlint#readme


Created	about 2 years ago
Last Updated	about 1 month ago
License	MIT
Maintainers	4
Releases	27
Direct Dependencies	`conventional-changelog-conventionalcommits`
Keywords	conventional-changelog, commitlint, commitlint-config and angular

README

Lint your conventional commits

@commitlint/config-conventional

Shareable commitlint config enforcing conventional commits.
Use with @commitlint/cli and @commitlint/prompt-cli.

⚠️
IMPORTANT	This is a direct replacement for @commitlint/config-angular prior to version 4. `config-angular` diverged from the conventional commit convention as of version 5. See #146 for details.

Getting started

npm install --save-dev @commitlint/config-conventional @commitlint/cli
echo "module.exports = {extends: ['@commitlint/config-conventional']};" > commitlint.config.js

Rules

Problems

The following rules are considered problems for @commitlint/config-conventional and will yield a non-zero exit code when not met.

Consult docs/rules for a list of available rules.

type-enum

condition: type is found in value
rule: always

value

[
  'build',
  'ci',
  'chore',
  'docs',
  'feat',
  'fix',
  'perf',
  'refactor',
  'revert',
  'style',
  'test'
]

echo "foo: some message" # fails
echo "fix: some message" # passes

type-case

description: type is in case value
rule: always
value
```
  'lowerCase'
```

echo "FIX: some message" # fails
echo "fix: some message" # passes

type-empty

condition: type is empty
rule: never

echo ": some message" # fails
echo "fix: some message" # passes

scope-case

condition: scope is in case value
rule: always

  'lowerCase'

echo "fix(SCOPE): some message" # fails
echo "fix(scope): some message" # passes

subject-case

condition: subject is in one of the cases ['sentence-case', 'start-case', 'pascal-case', 'upper-case']
rule: never

echo "fix(SCOPE): Some message" # fails
echo "fix(SCOPE): Some Message" # fails
echo "fix(SCOPE): SomeMessage" # fails
echo "fix(SCOPE): SOMEMESSAGE" # fails
echo "fix(scope): some message" # passes
echo "fix(scope): some Message" # passes

subject-empty

condition: subject is empty
rule: never

echo "fix:" # fails
echo "fix: some message" # passes

subject-full-stop

condition: subject ends with value
rule: never
value

'.'

echo "fix: some message." # fails
echo "fix: some message" # passes

header-max-length

condition: header has value or less characters
rule: always
value

echo "fix: some message that is way too long and breaks the line max-length by several characters" # fails
echo "fix: some message" # passes

@seadub/clang-format-lint

Author: Christopher Williams

Description: Validate and/or fix formatting of files via clang-format

Homepage: https://github.com/sgtcoolguy/clang-format-lint#readme


Created	4 months ago
Last Updated	4 months ago
License	MIT
Maintainers	1
Releases	2
Direct Dependencies	`commander`, `glob` and `p-limit`
Keywords	clang, clang-format and lint

README

clang-format-lint

A very simple wrapper around the clang-format npm package/binary.

Intended to be used to either validate existing files, or automatically fix the formatting on them.

Usage:

npx clang-format-lint [--fix] [--exec-limit [limit]] glob[ glob]*

e.g. To check if your source files match your formatting rules:

npx clang-format-lint android/src/**/*.java

e.g. To ensure your source files match your formatting rules:

npx clang-format-lint --fix android/src/**/*.java

New dependencies added: @commitlint/cli, @commitlint/config-conventional, @seadub/clang-format-lint, @seadub/danger-plugin-titanium-module, clang-format, commitizen, husky, lint-staged and titanium-docgen.

clang-format

Author: Unknown

Description: node wrapper around clang-format

Homepage: https://github.com/angular/clang-format#readme


Created	almost 5 years ago
Last Updated	9 days ago
License	Apache-2.0
Maintainers	3
Releases	65
Direct Dependencies	`async`, `glob` and `resolve`

README

clang-format

node.js module which wraps the native clang-format executable.

From the command-line:

$ npm install -g clang-format
$ clang-format -help

If your platform isn't yet supported, you can create the native binary from
the latest upstream clang sources, make sure it is stripped and optimized
(should be about 1.4MB as of mid-2015) and send a pull request to add it.

Checking formatting

Ensuring that changes to your code are properly formatted is an important part
of your development workflow. Note that the check-clang-format and
git-clang-format commands require Python to be globally available.

We recommend using a git pre-commit hook. You can configure this as follows:

add a precommit script to your package.json file:
```
"scripts": {
    "precommit": "check-clang-format"
}
```
By default, the user gets an error instructing them to run
./node_modules/.bin/git-clang-format. You may find it more ergonomic to set
up a package.json script, eg.
"scripts": { "format": "git-clang-format" }

In this case, add a second argument to the "precommit" script, giving the
error you'd like to print for users, eg.

"precommit": "check-clang-format \"yarn format\""
Add a devDependency on the husky package, which will add a
.git/hooks/pre-commit script, which in turn triggers the precommit
package.json script to run whenever someone adds a commit in this repository:
```
$ yarn add -D husky
```
or
```
npm install --save-dev husky
```

Why do this in a pre-commit hook? For one thing, it's faster to run
clang-format only on the changed files, especially as the repository grows.
Also, this lets you upgrade clang-format or change your settings without
needing to re-format the entire repository, while still enforcing that later
changes follow the new style.

Globbing files

$ clang-format --glob=folder/**/*.js

This will run clang-format once per file result, and show the total
formatted files at the end.
See node-glob for globbing semantics.

Compiling clang-format

For Linux, compile a statically linked MinSizeRel build:

cmake -G Ninja -DCMAKE_BUILD_TYPE=MinSizeRel -DLLVM_BUILD_STATIC=true ..
ninja clang-format

For Mac OS X, static linking is not required.

Windows

Windows snapshot builds to include in the release can be found at the
LLVM website.

Configure with:

cmake -G "Visual Studio 12" -DCMAKE_BUILD_TYPE=MinSizeRel ..

In the generated Visual Studio project, search for the clang-format binary in
the Solution Explorer window, right click and choose Build.

commitizen

Author: Jim Cummins

Description: Git commit, but play nice with conventions.

Homepage: https://github.com/commitizen/cz-cli


Created	almost 5 years ago
Last Updated	7 months ago
License	MIT
Maintainers	5
Releases	64
Direct Dependencies	`cachedir`, `cz-conventional-changelog`, `dedent`, `detect-indent`, `find-node-modules`, `find-root`, `fs-extra`, `glob`, `inquirer`, `is-utf8`, `lodash`, `minimist`, `shelljs`, `strip-bom` and `strip-json-comments`
Keywords	commit, pretty, format, conventional changelog and commitizen

This README is too long to show.

husky

Author: Typicode

Description: Prevents bad commit or push (git hooks, pre-commit/precommit, pre-push/prepush, post-merge/postmerge and all that stuff...)

Homepage: https://github.com/typicode/husky#readme


Created	over 5 years ago
Last Updated	13 days ago
License	MIT
Maintainers	1
Releases	150
Direct Dependencies	`chalk`, `ci-info`, `compare-versions`, `cosmiconfig`, `find-versions`, `opencollective-postinstall`, `pkg-dir`, `please-upgrade-node`, `slash` and `which-pm-runs`
Keywords	git, hook, hooks, pre-commit, precommit, post-commit, postcommit, pre-push, prepush, post-merge, postmerge, test and lint

This README is too long to show.

lint-staged

Author: Andrey Okonetchnikov

Description: Lint files staged by git

Homepage: https://github.com/okonet/lint-staged#readme


Created	about 4 years ago
Last Updated	6 days ago
License	MIT
Maintainers	1
Releases	139
Direct Dependencies	`chalk`, `commander`, `cosmiconfig`, `debug`, `dedent`, `execa`, `listr`, `log-symbols`, `micromatch`, `normalize-path`, `please-upgrade-node`, `string-argv` and `stringify-object`
Keywords	lint, git, staged, eslint, prettier, stylelint, code, quality, check, format and validate

This README is too long to show.

titanium-docgen

Author: Axway Appcelerator

Description: Generates Titanium API documentation in different formats

Homepage: https://github.com/appcelerator/docs-devkit#readme


Created	6 months ago
Last Updated	about 10 hours ago
License	Apache-2.0
Maintainers	1
Releases	11
Direct Dependencies	`colors`, `ejs`, `js-yaml`, `markdown-it` and `node-appc`
Keywords	titanium, docgen, documentation and docs

README

titanium-docgen

Generates Titanium API documentation in different formats

Installation

npm i titanium-docgen -D

Usage

node docgen [--addon-docs <PATH_TO_YAML_FILES] [--css <CSS_FILE>] [--format <EXPORT_FORMAT>] [--output <OUTPUT_DIRECTORY>] <PATH_TO_YAML_FILES>

For a description of each option. run docgen --help.

Supported formats

Format	Description
`addon`
`changes`
`html`	HTML files for the official docs at https://docs.appcelerator.com
`jsca`	JSCA content assist metadata
`jsduck`	https://github.com/senchalabs/jsduck
`json`	JSON metadata file
`json-raw`	Same as `json`, but with no pre-rendered markdown
`modulehtml`
`parity`
`solr`	Solr search index
`typescript`	TypeScript type definition file

@seadub/danger-plugin-titanium-module

Author: Chris Williams

Description: Eslint your code with Danger

Homepage: https://github.com/sgtcoolguy/danger-plugin-titanium-module#readme


Created	5 days ago
Last Updated	1 day ago
License	MIT
Maintainers	1
Releases	6
Direct Dependencies	`fs-extra` and `semver`
Keywords	danger, danger-plugin and eslint

README

danger-plugin-titanium-module

Eslint your code with Danger

Usage

Install:

yarn add danger-plugin-titanium-module --dev
# OR
npm install danger-plugin-titanium-module -D

At a glance:

// dangerfile.js
import lint from 'danger-plugin-titanium-module'

await lint()

Changelog

See the GitHub release history.

Contributing

See CONTRIBUTING.md.

Generated by 🚫 dangerJS against 79486ad

garymathews · 2020-02-05T21:46:47Z

@sgtcoolguy Yeah, but I decided to update sqlcipher too. Since customers usually ask us to update it every so often

sgtcoolguy · 2020-02-05T22:54:06Z

@garymathews i kept your commits in here too, including the sqlcipher update

ssjsamir

FR Passed able to build module and use the example application to test the module.

const dbobj = require('appcelerator.encrypteddatabase');

var win = Ti.UI.createWindow({ backgroundColor: 'white' });
var btn = Ti.UI.createButton({ title: 'Trigger' });

btn.addEventListener('click', accessDatabase);

win.add(btn);
win.open();

function accessDatabase() {
	dbobj.setPassword('secret');

	Ti.API.info('Opening DB ...');
	const instance = dbobj.open('test.db');

	instance.execute('CREATE TABLE IF NOT EXISTS user(name string, phone string);');
	instance.execute('insert into user (name, phone) values("oz", json(\'{"cell":"+491765", "home":"+498973"}\'));');

	const dataToInsertHandle = instance.execute('select user.phone from user where user.name==\'oz\'');
	const result = dataToInsertHandle.isValidRow() ? dataToInsertHandle.fieldByName('phone') : null;

	alert('Fetched data: ' + result);
	Ti.API.info('Closing DB ...');
	instance.close();

Test Environment

MacOS Catalina: 10.15.1 beta
Xcode: 11.3
Java Version: 1.8.0_131
Android NDK: 18.1.5063045
Node.js: 10.16.3
"NPM":"4.2.15-1","CLI":"7.1.2-7"
Pixel xl (7.1.1) Emulator

garymathews requested a review from jquick-axway January 28, 2020 00:43

jquick-axway approved these changes Jan 28, 2020

View reviewed changes

sgtcoolguy force-pushed the TIMOB-27727 branch from 4764c79 to 8e60418 Compare February 5, 2020 19:20

sgtcoolguy mentioned this pull request Feb 5, 2020

Build improvements #42

Closed

sgtcoolguy added 26 commits February 5, 2020 14:21

chore: update npm org name to @titanium-sdk

2f9326f

chore(package): add husky 3.0.9

9201fab

chore(package): update lockfile

5497174

chore(package): add @commitlint/cli 8.2.0

1da5b38

chore(package): update lockfile

a23d544

chore(package): add @commitlint/config-conventional 8.2.0

acc2bc6

chore(package): update lockfile

e67e76a

build: hook up commitlint config

d73cc75

chore(package): add lint-staged 9.4.2

431bbcc

chore(package): update lockfile

9e68863

build: add husky hooks

c1b4622

chore(package): add clang-format 1.2.3

d2e7242

chore(package): update lockfile

3b093e5

style: hook clang-format to lint-staged/husky

7f518e9

chore(package): add @seadub/clang-format-lint 0.0.2

c6e3090

chore(package): update lockfile

e1db80f

chore(package): update karma-titanium-launcher to 0.7.5

52e985a

chore(package): update lockfile

3facccb

chore(package): add commitizen 4.0.3

c3cc0a4

chore(package): update lockfile

a85f2d0

build: hook commitizen config/script

c699dd4

build: add npm scripts for lint/format/test

62948d3

chore(package): add titanium-docgen 0.2.0

61bcf40

chore(package): update lockfile

826f4f5

style: fix type whitelist for doc validation

2296cbb

style: add clang-format config files

6ff3ca6

sgtcoolguy added 2 commits February 5, 2020 14:22

test: use same sdk version as jenkins

9e33fa6

chore(release): update package.json version to 4.0.0

892967d

sgtcoolguy force-pushed the TIMOB-27727 branch from 8e60418 to 892967d Compare February 5, 2020 19:24

sgtcoolguy added 19 commits February 5, 2020 14:25

chore(package): update to titanium-docgen 4.2.0

ee2abc1

chore(package): update lockfile

02bd248

chore(package): update to danger 9.2.10

ef303a2

chore(package): update lockfile

5e71300

chore(package): update to husky 4.2.1

be3928a

chore(package): update lockfile

e2fd5ca

chore(package): update to lint-staged 10.0.7

d3533ec

chore: fix lint-staged to remove unnecessary git add commands

7e26e74

chore(package): update lockfile

e1f9ed3

chore(package): update to eslint 6.8.0

c77d0d0

chore(package): update lockfile

6693783

chore(package): update to eslint-config-axway 4.5.0

cfc76c3

chore(package): update lockfile

62bcdf0

chore(package): update to @commitlint/cli 8.3.5

36babb9

chore(package): update lockfile

715e991

chore(package): update to @commitlint/config-conventional 8.3.4

d3065fe

chore(package): update lockfile

882a70f

chore(package): update to socket.io 2.3.0

c6b6dbd

chore(package): update lockfile

79486ad

tidev deleted a comment from build Feb 5, 2020

ssjsamir self-requested a review February 6, 2020 11:12

ssjsamir approved these changes Feb 6, 2020

View reviewed changes

ssjsamir merged commit ff743b7 into tidev:master Feb 6, 2020

chore(android): migrate to gradle #44

chore(android): migrate to gradle #44

Conversation

garymathews commented Jan 28, 2020 • edited

jquick-axway left a comment

Choose a reason for hiding this comment

sgtcoolguy commented Feb 5, 2020

build commented Feb 5, 2020 • edited

@commitlint/cli

Getting started

@commitlint/config-conventional

Getting started

Rules

Problems

type-enum

type-case

type-empty

scope-case

subject-case

subject-empty

subject-full-stop

header-max-length

clang-format-lint

clang-format

From the command-line:

Checking formatting

Globbing files

Compiling clang-format

Windows

titanium-docgen

Installation

Usage

Supported formats

danger-plugin-titanium-module

Usage

Changelog

Contributing

garymathews commented Feb 5, 2020

sgtcoolguy commented Feb 5, 2020

ssjsamir left a comment

Choose a reason for hiding this comment

garymathews commented Jan 28, 2020 •

edited

build commented Feb 5, 2020 •

edited