Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): replace Support libraries with AndroidX #11428

Merged
merged 5 commits into from Jan 15, 2020

Conversation

jquick-axway
Copy link
Contributor

JIRA:

Summary:

  • Replaced all Google Support library references with AndroidX.
  • Updated to newest version of all Google libraries.
  • Enabled "jetifier" tool support for app builds.
    • Allows backward compatibility with old modules using Google Support libraries.
  • TIMOB-27696 Added ability to extend app's "gradle.properties" file.
    • Can now add the following file to project: ./platform/android/gradle.properties

Test AndroidX:
(Perform test on Android device and emulator. Also test on Android 4.4.)

  1. Build and run kitchensink-v2 on Android.
  2. Tap on every row, verifying that all features work.

Test "gradle.properties" Extension:

  1. Create a Classic Titanium app project.
  2. Add the below gradle.properties file under project's ./platform/android dir.
  3. Add the below build.gradle file under project's ./platform/android dir.
  4. Build for Android.
  5. In the build log, look for message: @@@ my.property = Hello World

./platform/android/gradle.properties

my.property=Hello World

./platform/android/build.gradle

println('@@@ my.property = ' + project.findProperty('my.property'))

@build
Copy link
Contributor

build commented Jan 11, 2020

Warnings
⚠️

android/cli/lib/gradle-wrapper.js#L235 - android/cli/lib/gradle-wrapper.js line 235 – 'url.parse' was deprecated since v11.0.0. Use 'url.URL' constructor instead. (node/no-deprecated-api)

Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6550 tests are passing.
(There are 700 skipped tests not included in that total)

Generated by 🚫 dangerJS against 40aef6a

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Tested using the test steps mentioned above.

Test Environment

MacOS Catalina 10.15.1 beta
Node.js 10.16.3
"NPM":"4.2.15-1","CLI":"7.1.2"
Google Pixel 7.1.1 Emulator
Nexus 5X 4.2.2 Emulator
Google Pixel 10 Device

@ssjsamir ssjsamir merged commit 0558c28 into tidev:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants