-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): AndroidX support #11409
Conversation
|
@sgtcoolguy Updated |
@hansemannn Something definitely went wrong here. The mocha test suite fails to build. My guess is that there's a mixture of the androidx support in the SDk and legacy android support libraries in the playservices/maps modules.
|
Oh, do we compile the sample app with ti.playservices? It definitely needs to be recompiled (with a build.gradle) in order to work with Android X. Same goes for all modules that use ti.playservices, e.g. ti.map. Is there a chance to build with a new (prerelease) version of these? Then I can update them to gradle and try again. |
@jquick-axway is taking over the further adjustments as discussed with him. |
@hansemannn, I'm closing this PR in favor of PR #11428 Notes:
|
JIRA: https://jira.appcelerator.org/browse/TIMOB-26472
A few notes:
labelVisibilityMode
instead (fixes TIMOB-26905 btw)implementation "com.android.support:appcompat-v7:${project.ext.tiSupportLibVersion}"
left over which I wasn't sure how to handle so far.The sample app works fine!