Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): extend gradle.properties / local.properties #11408

Closed
wants to merge 5 commits into from

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn commented Dec 22, 2019

JIRA: https://jira.appcelerator.org/browse/TIMOB-27696

Also adds the generated Android Studio files to the .gitignore

@build build added this to the 9.0.0 milestone Dec 22, 2019
@build
Copy link
Contributor

build commented Dec 22, 2019

Warnings
⚠️

🔍 Can't find junit reports at ./junit.*.xml, skipping generating JUnit Report.

⚠️

android/cli/lib/gradle-wrapper.js#L231 - android/cli/lib/gradle-wrapper.js line 231 – 'url.parse' was deprecated since v11.0.0. Use 'url.URL' constructor instead. (node/no-deprecated-api)

Messages
📖 🎉 Another contribution from our awesome community member, hansemannn! Thanks again for helping us make Titanium SDK better. 👍
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Generated by 🚫 dangerJS against 9470bba

@hansemannn
Copy link
Collaborator Author

@sgtcoolguy Updated

@jquick-axway
Copy link
Contributor

@hansemannn, I'm closing this PR in favor of PR #11428

It's implemented in a similar way. It still appends the app project's gradle.properties to the generated one. But I would prefer to keep the gradle-wrapper.js script as generic as possible so that we can use it on non-Titanium app projects too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants