-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENV cleanup #32
Comments
This part of code requires some attention, bigtuna should use Bundler.with_clear_env there but something didn't work for us when creating bigtuna. I'll take a look into this part and try to fix it -- no params should be set there. |
does this mean that bigtuna is a CI for rails-only applications? |
Nope, it runs arbitrary shell scripts. The env was set up so that it also supports rails apps. |
also |
You can try the branch: And see if it works for you: it uses the Bundler.with_clean_env and doesn't set any env's. If you want to set the env yourself it might be insufficient (although I'm not sure) to use ENV_NAME=env_value script/to/run You probably want to use 'env' command Let us know if the solution works for you! :-) |
|
+1 |
Recently discovered that we hadn't restarted our workers when we tried this, so we discovered a small problem - not one necessarily for Bigtuna to fix, but some people might run into this. Since bundler captures the
In the future it may be useful for Bigtuna to have an "environment variables" configuration section which will be applied to the entire build process (the above is an example - our build process is more complicated, and we have to set the environment variables on every line). |
The issue is resolved, branch is merged into dev and regarding wuputah's comment I've created https://github.com/appelier/bigtuna/issues/issue/44 |
Why do we dupe ENV, set RAILS_ENV to test and revert back to previous ENV? There are some steps I do not necessarily want to execute into test ENV. Maybe we should make this behaivour parametrizable?
The text was updated successfully, but these errors were encountered: