ENV cleanup

[knoopx]

Why do we dupe ENV, set RAILS_ENV to test and revert back to previous ENV? There are some steps I do not necessarily want to execute into test ENV. Maybe we should make this behaivour parametrizable?

[michalbugno]

This part of code requires some attention, bigtuna should use Bundler.with_clear_env there but something didn't work for us when creating bigtuna. I'll take a look into this part and try to fix it -- no params should be set there.

[knoopx]

does this mean that bigtuna is a CI for rails-only applications?

[michalbugno]

Nope, it runs arbitrary shell scripts. The env was set up so that it also supports rails apps.

[knoopx]

also db:migrate RAILS_ENV=development does not override the default one set by with_clear_env

[michalbugno]

You can try the branch:
https://github.com/appelier/bigtuna/tree/runner_env_fix

And see if it works for you: it uses the Bundler.with_clean_env and doesn't set any env's. If you want to set the env yourself it might be insufficient (although I'm not sure) to use ENV_NAME=env_value script/to/run

You probably want to use 'env' command
env ENV_NAME=env_value script/to/run

Let us know if the solution works for you! :-)

[wuputah]

+1. Confirmed this works great for us on a fairly quirky setup - our setup had issues under the default setup (we had to change BigTuna to delete the RAILS_ENV environment variable under the default setup).

[cldwalker]

+1

[wuputah]

Recently discovered that we hadn't restarted our workers when we tried this, so we discovered a small problem - not one necessarily for Bigtuna to fix, but some people might run into this. Since bundler captures the ENV when it is loaded in config/boot.rb, the environment variable BUNDLE_GEMFILE is set (Rails sets this in config/boot.rb) even inside Bundler.with_clean_env. This will affect any build scripts trying to use Bundler. The workaround is to use the --gemfile option with bundle install and use BUNDLE_GEMFILE=%build_dir%/Gemfile in your build script. For example:

bundle install --path=%project_dir%/bundle --deployment --gemfile=%build_dir%/Gemfile
BUNDLE_GEMFILE=%build_dir%/Gemfile bundle exec rake

In the future it may be useful for Bigtuna to have an "environment variables" configuration section which will be applied to the entire build process (the above is an example - our build process is more complicated, and we have to set the environment variables on every line).

[michalbugno]

The issue is resolved, branch is merged into dev and regarding wuputah's comment I've created https://github.com/appelier/bigtuna/issues/issue/44