Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL: Text field for output too short #78

Open
gorenje opened this issue Jul 15, 2011 · 2 comments
Open

MySQL: Text field for output too short #78

gorenje opened this issue Jul 15, 2011 · 2 comments

Comments

@gorenje
Copy link

gorenje commented Jul 15, 2011

Hi,

the output fields on build_parts and builds are both text types, which means that when using MySQL* these are truncated to 64K characters. This might be fine for most things, but is insufficient if the output of bundle install and rake db:migrate are included and then a bunch of test outputs.

class OutputNeedsToBeLongtextWithMysql < ActiveRecord::Migration
  def self.up
    change_column :build_parts, :output, :longtext
    change_column :builds, :output, :longtext
  end

  def self.down
    change_column :build_parts, :output, :text
    change_column :builds, :output, :text
  end
end

the migration has no effect using sqlite but does change the column to longtext when using mysql. The commit is on a branch on my fork.

*=http://www.electrictoolbox.com/maximum-length-mysql-text-field-types/

@antekpiechnik
Copy link
Member

Hey man, would you like to make this a pull request ?

@gorenje
Copy link
Author

gorenje commented Jan 17, 2012

no problem, created #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants