Skip to content

Commit

Permalink
Fix #12739. Keep namespace when triggering with an Event. Close jquer…
Browse files Browse the repository at this point in the history
  • Loading branch information
cobrajs authored and dmethvin committed Oct 19, 2012
1 parent b386080 commit c6cf30a
Show file tree
Hide file tree
Showing 3 changed files with 40 additions and 2 deletions.
3 changes: 2 additions & 1 deletion AUTHORS.txt
Original file line number Diff line number Diff line change
Expand Up @@ -134,4 +134,5 @@ Nikita Govorov <nikita.govorov@gmail.com>
Michael Pennisi <mike@mikepennisi.com>
Markus Staab <markus.staab@redaxo.de>
Daniel Gálvez <dgalvez@editablething.com>
James Huston <james@jameshuston.net>
James Huston <james@jameshuston.net>
Allen J Schmidt Jr <cobrasoft@gmail.com>
2 changes: 1 addition & 1 deletion src/event.js
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ jQuery.event = {
// Event object or event type
var cache, exclusive, i, cur, old, ontype, special, handle, eventPath, bubbleType,
type = event.type || event,
namespaces = [];
namespaces = event.namespace ? event.namespace.split(".") : [];

// focus/blur morphs to focusin/out; ensure we're not firing them right now
if ( rfocusMorph.test( type + jQuery.event.triggered ) ) {
Expand Down
37 changes: 37 additions & 0 deletions test/unit/event.js
Original file line number Diff line number Diff line change
Expand Up @@ -2923,3 +2923,40 @@ asyncTest("trigger click on checkbox, fires change event", function() {
start();
}).trigger("click");
});

test( "Namespace preserved when passed an Event (#12739)", function() {
expect( 4 );

var markup = jQuery(
"<div id='parent'><div id='child'></div></div>"
),
triggered = 0,
fooEvent;

markup.find("div")
.addBack()
.on( "foo.bar", function( e ) {
if ( !e.handled ) {
triggered++;
e.handled = true;
equal( e.namespace, "bar", "namespace is bar" );
jQuery( e.target ).find("div").each(function() {
jQuery( this ).triggerHandler( e );
});
}
})
.on( "foo.bar2", function( e ) {
ok( false, "foo.bar2 called on trigger " + triggered + " id " + this.id );
});

markup.trigger("foo.bar");
markup.trigger( jQuery.Event("foo.bar") );
fooEvent = jQuery.Event("foo");
fooEvent.namespace = "bar";
markup.trigger( fooEvent );
markup.remove();

equal( triggered, 3, "foo.bar triggered" );
});


0 comments on commit c6cf30a

Please sign in to comment.