Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Considering shift from react-select-plus to react-select v2 #512

Open
moyuanhuang opened this issue Dec 17, 2018 · 4 comments
Open

Considering shift from react-select-plus to react-select v2 #512

moyuanhuang opened this issue Dec 17, 2018 · 4 comments

Comments

@moyuanhuang
Copy link
Contributor

This issue is based on the assumption that we're only using react-select-plus instead of react-select. Correct me if I'm wrong, and I'll close the issue :)

The purpose of using react-select-plus was to support option groups in the dropdown, a feature that react-select didn't have.

Now that the v2 version of react-select added support this feature (I think they just back merged the code from react-select-plus), react-select-plus is not longer 'actively maintained'. We should consider changing the package from react-select-plus to react-select for the sake of compatibility. It's good also because react-select v2 now support a lot of new features that could probably enable us to do more interesting things! https://react-select.com/home

@gthomas-appfolio
Copy link
Contributor

Hi @moyuan, thanks we should do that, there were just some styling changes (border, etc) that we’d need to rework to be themeable.
Current open PR is tracked here: #461

@phwebi
Copy link
Contributor

phwebi commented Jan 29, 2020

@moyuanhuang
Copy link
Contributor Author

@phwebi Do we have any plans on this? I've got a working branch

@phwebi
Copy link
Contributor

phwebi commented Jan 29, 2020

@moyuanhuang I saw this issue when I was browsing yesterday and I think it'd be nice to do! Feel free to make a PR if your branch is up to date and I can help review 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants