Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add coordinate-based APIs for gesture calls #843

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

mykola-mokhnach
Copy link

@mykola-mokhnach mykola-mokhnach commented Jan 30, 2024

BREAKING CHANGE: The /wda/tap/:uuid endpoint has been replaced by /wda/element/:uuid/tap and /wda/tap ones

Currently the way these APIs are called from xcuitest is suboptimal as we have to lookup for the application object every time they are called without elementId, which creates unnecessary overhead and is potentially error-prone (see appium/appium#19739)

The change ensures WDA assigns activeApplication instance itself without making other unnecessary calls.

After this change is published it is necessary to update xcuitest driver to use the new API endpoints for cases where elementId is unset

Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mykola-mokhnach mykola-mokhnach merged commit feda373 into master Jan 31, 2024
46 checks passed
@mykola-mokhnach mykola-mokhnach deleted the gestures_coord branch January 31, 2024 14:20
github-actions bot pushed a commit that referenced this pull request Jan 31, 2024
## [6.0.0](v5.15.8...v6.0.0) (2024-01-31)

### ⚠ BREAKING CHANGES

* The  /wda/tap/:uuid endpoint has been replaced by /wda/element/:uuid/tap and /wda/tap ones

### Features

* Add coordinate-based APIs for gesture calls ([#843](#843)) ([feda373](feda373))
Copy link

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants