feat: add pinWithKeyEvent to put keys one by one for pin as key evnets #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/unlock-helpers.js
Outdated
| const KEYCODE_NUMPAD_ENTER = 66; | ||
| const KEYCODE_POWER = 26; | ||
| const KEYCODE_WAKEUP = 224; // Can work over API Level 20 | ||
| const UNLOCK_WAIT_TIME = 100; | ||
| const HIDE_KEYBOARD_WAIT_TIME = 100; | ||
| const INPUT_KEYS_WAIT_TIME = 100; | ||
| // mapping of Android keycode and numbers | ||
| const ANDROID_KEY_CODE_NUMBER = { | ||
| '0': 7, |
There was a problem hiding this comment.
I believe this mapping could be generated dynamically, there is no need to hardcode each item
There was a problem hiding this comment.
const ZERO_KEY_CODE = 7;
result = _.range(10).reduce((acc) => {
acc[String.fromCharCode('0'.charCodeAt(0) + _.size(acc))] = ZERO_KEY_CODE + _.size(acc);
return acc;
}, {});
lib/unlock-helpers.js
Outdated
|
|
||
| // Some devices accept entering the code without pressing the Enter key | ||
| // When I rushed commands without this wait before pressKeyCode, rarely UI2 sever crashed | ||
| await sleep(UNLOCK_WAIT_TIME); |
There was a problem hiding this comment.
can we extract this duplicated block into a separate function to avoid duplication?
mykola-mokhnach
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some devices like Samsung have customized keyboard in
pin.Then, it is reliable to send keys as keycode like
passwordrather than finding numbers with ids. I named the strategy aspinWithKeyEventfor now. (Suggestions are welcome)As backward compatibility,
pinshould be there, but thepinUnlockWithKeyEventcan be used as a fallback method when no system key ids in the pin view. Afaik, this fallback is pretty enough.After this change: