Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The command of retrieve device by adb devices is incorrect #60

Closed
xuanzhaopeng opened this issue Aug 11, 2017 · 2 comments
Closed

The command of retrieve device by adb devices is incorrect #60

xuanzhaopeng opened this issue Aug 11, 2017 · 2 comments

Comments

@xuanzhaopeng
Copy link
Contributor

xuanzhaopeng commented Aug 11, 2017

Source code : https://github.com/appium/appium-docker-android/blob/master/Appium/generate_config.sh#L44

devices=($(adb devices | grep -oP "\K([^ ]+)(?=\sdevice(\W|$))"))

The reason is when I create a container, there is no "device", it will be "unauthorized"

should be

devices=($(adb devices | grep -oP "\K([^ ]+)(?=\s(device|unauthorized)(\W|$))"))
@SrinivasanTarget
Copy link
Member

@xuanzhaopeng Would you like to raise a PR?

@red-avtovo
Copy link
Contributor

I'm not sure, that we should "see" unauthorized devices as soon as we are trying to generate node config from props, that we are requesting from devices, like
os_version="$(adb -s $name shell getprop ro.build.version.release | tr -d '\r')"
This command will fail and we will get a broken config, which will affect tests evaluation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants