fix: Fix compose driver for compose 1.6.x method signature change #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gradle wrapper --gradle-version 8.2
|
@KazuCocoa @mykola-mokhnach could you please help, The tests passed on API 29 but failed on all other API level. |
|
I guess slow ci related. let me retry |
|
Yep, just checked the test have failed similarly on last few |
| it.call(EspressoServerRunnerTest.composeTestRule.onRoot(useUnmergedTree = true), true, null) | ||
| // INFO: Compose API has added the method parameter in compose 1.6.x+ | ||
| if (it.parameters.size == 4) { | ||
| it.call(EspressoServerRunnerTest.composeTestRule.onRoot(useUnmergedTree = true), true, null, true) |
There was a problem hiding this comment.
we may extract the first argument to avoid unnecessary code duplication
mykola-mokhnach
approved these changes
Apr 11, 2024
KazuCocoa
approved these changes
Apr 12, 2024
espresso-server/app/src/androidTest/java/io/appium/espressoserver/lib/model/SourceDocument.kt
Show resolved
Hide resolved
github-actions bot
pushed a commit
that referenced
this pull request
Apr 12, 2024
## [2.38.1](v2.38.0...v2.38.1) (2024-04-12) ### Bug Fixes * Fix compose driver for compose 1.6.x method signature change ([#995](#995)) ([41f1b8d](41f1b8d))
|
🎉 This PR is included in version 2.38.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compose library has change method signature of
fetchSemanticsNodes. This PR addresses that.https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/SemanticsNodeInteraction.kt;l=59;bpv=1;bpt=0;drc=78d5dc8c9b42c32b0c8518c72181c19620a71c05;dlc=7aed8c7ff9c9355d5dfeb28021f8725d58dc4c6f